Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional response codes for extending alias support #135

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

Neeharika-Sompalli
Copy link
Member

Closes #134

For extending alias support to all transactions and Queries, added additional response codes to be returned if account ID given is invalid or does not exist.

services/response_code.proto Show resolved Hide resolved
services/response_code.proto Show resolved Hide resolved
SimiHunjan
SimiHunjan previously approved these changes Jan 14, 2022
qnswirlds
qnswirlds previously approved these changes Jan 15, 2022
steven-sheehy
steven-sheehy previously approved these changes Jan 18, 2022
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj tinker-michaelj merged commit dff1949 into develop Jan 20, 2022
@tinker-michaelj tinker-michaelj deleted the HIP-32-0134-D-additionalResponseCodes branch January 20, 2022 15:58
andrewb1269hg added a commit that referenced this pull request Oct 29, 2024
commit 0521f16 add response codes
commit 095591b changed auto_renew_account_number to auto_renew_account_id in topic.proto (#293)
commit 12546c0 Add pending rewards per node (#320)
commit 1bbec1f Key list (#34)
commit 1f12fc0 add ids instead
commit 2269435 add FcCustomFee
commit 22cc530 Update README.md
commit 24ac73b remove deleted flag
commit 2554e80 Add Staking Reward related fields from `MerkleNetworkContext` (#295)
commit 28f0637 Additional response codes for Approval/Allowance (#155)
commit 2bbbee4 Add `StakingNodeInfo` for MerkleStakingInfo (#277)
commit 2dee337 address review comments
commit 33bf55d fix imports
commit 39be677 typo
commit 3a4914b add imports
commit 3ff7242 update package
commit 403535c change to ids only for token
commit 4a6c9ff Add payer account ID
commit 4e6fdf4 revert updating alias as the feature is extended to 0.24 (#158)
commit 4fd42b4 Update documentation for HIP-564 (#238)
commit 50572b4 change to uint64
commit 5c934b5 add TransactionReceiptEntries
commit 623f0a5 update comment
commit 624d57f Modifications for the auto account create (#121)
commit 637920a add weight to NodeStake
commit 63cb1b3 add missing fields and change allowance names
commit 6550604 Revert "Metadata hips 646 657 765 (#319)" (#322)
commit 6af29e3 Initial commit
commit 7051729 use snake case throughout protobufs (#294)
commit 70622f3 Update services/crypto_update.proto
commit 706c0d6 remove TokenCustomFee
commit 72aa494 chore: Rename payload to transaction
commit 72f7bb1 add weight to NodeStake
commit 761bab0 Remove unused `deleted` flag from `TokenRelation` (#330)
commit 7bbf1d5 Change allowance maps on `Account` PBJ Object (#269)
commit 7d6a14f fix imports
commit 85c3446 change to ids for account and token
commit 89b75cb Update common.proto, token.proto, token-relation.protp and classes that rely on it to use AccountID and TokenID (#290)
commit 89d8993 update response code
commit 8b24fb6 chnage response code
commit 8ccddad Add Allowance Transactions to HederaFunctionality (#154)
commit 8e6dd22 Update CryptoGetAccountBalance.proto (#14)
commit 8fa7541 Add number of pending airdrops on `Account` (#402)
commit 95c2b60 Update documentation for HIP-564 (#238)
commit 9880632 add weight to NodeStake
commit 9895c56 add ids instead
commit a4f1a06 Changes to support  auto account creation (#119)
commit a644ad4 chore: Rename payload to transaction (#401)
commit a841027 feat: add token reject transaction (#351)
commit a94bdf4 remove import
commit aa2608e change order of fields
commit ad7d2c0 Add the TransactionRecordEntry type for the record cache.
commit ae1b074 review comments
commit b37fa80 docs
commit b430338 re-add deprecated fields to Transaction (#29)
commit c696944 add ids instead
commit cd8ca44 address review comments
commit cffdb12 Sync from develop
commit d336767 Add missing fields in Account (#270)
commit d33b764 Hip 904 pending airdrops protobuf changes (#362)
commit d42b5b6 Update services/contract_create.proto
commit d43443e add FcCustomFee
commit d5d0b6e fix imports
commit dd1a57f address review comments
commit dff1949 Additional response codes for extending alias support (#135)
commit e112f07 update number of pending airdrops
commit e126b0f Add `ACCOUNT_IS_IMMUTABLE` response (#244)
commit e1e3aa2 change to ids for topic and file also
commit e97e29b Update services/contract_update.proto
commit e9aa737 change to bits
commit f008f0d address review comments
commit f387dda Add TransactionReceiptEntries to RecordCache (#404)
commit fd3af5f add weight to NodeStake

Signed-off-by: Andrew Brandt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-32 Add additional response codes for extending alias support
5 participants