Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual_address_update disable #249

Closed
wants to merge 4 commits into from
Closed

Add virtual_address_update disable #249

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e37749
Add virtual_address_update disable
Nana-EC Dec 6, 2022
b3b7b75
remove disable and simplify
Nana-EC Dec 6, 2022
2e78f38
fixed broken part of
Nana-EC Dec 6, 2022
f2dbe8b
fixed comment
Nana-EC Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions services/crypto_update.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,8 @@ message CryptoUpdateTransactionBody {
oneof virtual_address_update {
/**
* The virtual address to be added.
* The address one successfully addition becomes par tof the accounts ACTIVE virtual addresses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: part of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

*/
VirtualAddress add = 20;

/**
* The 20-byte EVM address of the virtual address that is being removed.
*/
bytes remove = 21;
}
}