Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RosterValidator throw checked exception #15766

Open
Tracked by #14706
kfa-aguda opened this issue Oct 2, 2024 · 2 comments · May be fixed by #17187
Open
Tracked by #14706

Make RosterValidator throw checked exception #15766

kfa-aguda opened this issue Oct 2, 2024 · 2 comments · May be fixed by #17187
Assignees
@timfn-hg
Labels
Platform Tickets pertaining to the platform

Comments

@kfa-aguda
Copy link
Contributor

kfa-aguda commented Oct 2, 2024 •
edited by poulok
Loading

And update all references accordingly, especially in its use in putActiveRoster.

  1. InvalidRosterException should extend Exception, not RuntimeException
  2. RosterValidator validate method should throw InvalidRosterException
  3. RosterStateModifier#putActiveRoster updated.
@kfa-aguda kfa-aguda mentioned this issue Oct 2, 2024
Closed
@edward-swirldslabs
Copy link
Contributor

Specifically, InvalidRosterException becomes a checked exception instead of a runtime exception.

@poulok poulok added the Platform Tickets pertaining to the platform label Oct 4, 2024
@poulok
Copy link
Member

poulok commented Oct 9, 2024

@kfa-aguda, please add this to the TSS Roster epic

@kfa-aguda kfa-aguda mentioned this issue Oct 9, 2024
Open
@timfn-hg timfn-hg self-assigned this Dec 27, 2024
@timfn-hg timfn-hg linked a pull request Jan 2, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timfn-hg timfn-hg

Labels
Platform Tickets pertaining to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Refactor InvalidRosterException to be a checked exception hashgraph/hedera-services
4 participants
@poulok @edward-swirldslabs @kfa-aguda @timfn-hg