chore: Remove inexact-weight TSS implementation #17214

tinker-michaelj · 2025-01-04T04:17:32Z

Description:

Signed-off-by: Michael Tinker <[email protected]>

codacy-production · 2025-01-04T04:44:56Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.22% (target: -1.00%)	✅ 92.50%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`f3ec5d1`)	95932	65322	68.09%
Head commit (`437d47b`)	94870 (-1062)	64389 (-933)	67.87% (-0.22%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#17214)	40	37	92.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-01-04T04:45:33Z

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.11%. Comparing base (f3ec5d1) to head (437d47b).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
.../com/hedera/node/app/info/DiskStartupNetworks.java	80.00%	0 Missing and 1 partial ⚠️
...va/com/hedera/node/app/tss/TssBlockHashSigner.java	80.00%	1 Missing ⚠️
...dera/node/app/workflows/handle/HandleWorkflow.java	50.00%	1 Missing ⚠️
...p/workflows/handle/steps/PlatformStateUpdates.java	75.00%	0 Missing and 1 partial ⚠️
...java/com/swirlds/platform/crypto/KeysAndCerts.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17214      +/-   ##
============================================
- Coverage     64.33%   64.11%   -0.23%     
+ Complexity    20942    20715     -227     
============================================
  Files          2555     2537      -18     
  Lines         96169    95087    -1082     
  Branches      10054     9971      -83     
============================================
- Hits          61873    60963     -910     
+ Misses        30655    30520     -135     
+ Partials       3641     3604      -37

Files with missing lines	Coverage Δ
.../src/main/java/com/hedera/hapi/util/HapiUtils.java	`61.71% <ø> (+0.82%)`	⬆️
...-app/src/main/java/com/hedera/node/app/Hedera.java	`52.06% <100.00%> (-5.32%)`	⬇️
...rc/main/java/com/hedera/node/app/ServicesMain.java	`31.42% <ø> (+0.87%)`	⬆️
...com/hedera/node/app/blocks/BlockStreamManager.java	`100.00% <ø> (ø)`
...a/node/app/blocks/impl/BlockStreamManagerImpl.java	`93.58% <100.00%> (-0.34%)`	⬇️
...m/hedera/node/app/services/ServiceScopeLookup.java	`45.45% <ø> (-2.38%)`	⬇️
...om/hedera/node/app/store/ReadableStoreFactory.java	`81.39% <ø> (-0.43%)`	⬇️
...om/hedera/node/app/store/WritableStoreFactory.java	`86.04% <ø> (-2.85%)`	⬇️
...n/java/com/hedera/node/app/tss/TssBaseService.java	`100.00% <ø> (+50.00%)`	⬆️
...va/com/hedera/node/app/tss/TssBaseServiceImpl.java	`100.00% <100.00%> (+33.54%)`	⬆️
... and 19 more

... and 19 files with indirect coverage changes

Signed-off-by: Michael Tinker <[email protected]>

Neeharika-Sompalli · 2025-01-06T16:24:02Z

hedera-node/hedera-app/src/main/java/com/hedera/node/app/tss/schemas/V059TssBaseSchema.java

+/**
+ * Schema removing the states added in {@code 0.56.0} and {@code 0.58.0} for the inexact weights TSS scheme.
+ */
+@Deprecated(forRemoval = true, since = "0.59.0")


This is not deprecated right ?

...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/config/AddressBookConfig.java

hedera-node/hedera-app/src/test/resources/bootstrap/network.json

version.txt

Neeharika-Sompalli · 2025-01-06T16:54:59Z

platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/MerkleStateRoot.java

+            if (!Map.of().equals(stateMetadata)) {
+                stateMetadata.remove(stateKey);


Why do we need this ?

+1. The if seems unnecessary. The remove call should be unconditional.

It's necessary because MerkleStateRoot.getWritableStates() here returns the immutable Map.of() singleton for a service that has not registered any states; and this singleton throws UnsupportedOperationException on receiving remove().

I can go into more detail if you want; but either this or replacing Map.of() with new HashMap<>() at the linked method is necessary.

Signed-off-by: Michael Tinker <[email protected]>

Neeharika-Sompalli

Overall LGTM! Have two comments though. Thanks @tinker-michaelj

rbarkerSL

Approval applies to version.txt

anthony-swirldslabs

LGTM, but there's a comment above from @Neeharika-Sompalli that I agree needs fixing.

tinker-michaelj added 2 commits January 3, 2025 21:47

intermezzo

0a642c5

Signed-off-by: Michael Tinker <[email protected]>

fix unit test

c8faac1

Signed-off-by: Michael Tinker <[email protected]>

tinker-michaelj requested review from a team as code owners January 4, 2025 04:17

tinker-michaelj requested review from edward-swirldslabs, mxtartaglia-sl, OlegMazurov and iwsimon January 4, 2025 04:17

spotless

589dcf0

Signed-off-by: Michael Tinker <[email protected]>

tinker-michaelj added this to the v0.59 milestone Jan 4, 2025

tinker-michaelj self-assigned this Jan 4, 2025

fix checkModuleInfo

5c0b59b

Signed-off-by: Michael Tinker <[email protected]>

stabilize ci

c401880

Signed-off-by: Michael Tinker <[email protected]>

tinker-michaelj requested review from a team as code owners January 4, 2025 15:28

tinker-michaelj requested review from artemananiev, dalvizu and leninmehedy January 4, 2025 15:28

tinker-michaelj added 5 commits January 4, 2025 09:56

Remove T1 Functionality enum values

ec68992

Signed-off-by: Michael Tinker <[email protected]>

spotless

77bd07c

Signed-off-by: Michael Tinker <[email protected]>

fix unit test

6c05c2d

Signed-off-by: Michael Tinker <[email protected]>

Delete T1 KeyLoader code

c86700b

Signed-off-by: Michael Tinker <[email protected]>

Remove T1 network.proto fields

ab226b5

Signed-off-by: Michael Tinker <[email protected]>

Neeharika-Sompalli reviewed Jan 6, 2025

View reviewed changes

...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/config/AddressBookConfig.java Show resolved Hide resolved

Neeharika-Sompalli reviewed Jan 6, 2025

View reviewed changes

hedera-node/hedera-app/src/test/resources/bootstrap/network.json Show resolved Hide resolved

rbarkerSL requested changes Jan 6, 2025

View reviewed changes

version.txt Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Jan 6, 2025

View reviewed changes

Use SNAPSHOT for version.txt

437d47b

Signed-off-by: Michael Tinker <[email protected]>

mxtartaglia-sl approved these changes Jan 6, 2025

View reviewed changes

Neeharika-Sompalli approved these changes Jan 6, 2025

View reviewed changes

rbarkerSL approved these changes Jan 6, 2025

View reviewed changes

anthony-swirldslabs reviewed Jan 6, 2025

View reviewed changes

edward-swirldslabs approved these changes Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove inexact-weight TSS implementation #17214

chore: Remove inexact-weight TSS implementation #17214

tinker-michaelj commented Jan 4, 2025 •

edited

Loading

codacy-production bot commented Jan 4, 2025 •

edited

Loading

codecov bot commented Jan 4, 2025 •

edited

Loading

Neeharika-Sompalli Jan 6, 2025

Neeharika-Sompalli Jan 6, 2025

anthony-swirldslabs Jan 6, 2025

tinker-michaelj Jan 7, 2025 •

edited

Loading

Neeharika-Sompalli left a comment

rbarkerSL left a comment

anthony-swirldslabs left a comment

		if (!Map.of().equals(stateMetadata)) {
		stateMetadata.remove(stateKey);

chore: Remove inexact-weight TSS implementation #17214

Are you sure you want to change the base?

chore: Remove inexact-weight TSS implementation #17214

Conversation

tinker-michaelj commented Jan 4, 2025 • edited Loading

codacy-production bot commented Jan 4, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Jan 4, 2025 • edited Loading

Codecov Report

Neeharika-Sompalli Jan 6, 2025

Choose a reason for hiding this comment

Neeharika-Sompalli Jan 6, 2025

Choose a reason for hiding this comment

anthony-swirldslabs Jan 6, 2025

Choose a reason for hiding this comment

tinker-michaelj Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

rbarkerSL left a comment

Choose a reason for hiding this comment

anthony-swirldslabs left a comment

Choose a reason for hiding this comment

tinker-michaelj commented Jan 4, 2025 •

edited

Loading

codacy-production bot commented Jan 4, 2025 •

edited

Loading

codecov bot commented Jan 4, 2025 •

edited

Loading

tinker-michaelj Jan 7, 2025 •

edited

Loading