feat: SCSC metrics for #TXs that fail pureCheck

[david-bakin-sl]

Description:

SCSC metrics for #TXs that fail pureCheck:

• counts for CONTRACT_CREATE / CONTRACT_CALL / ETHEREUM_TRANSACTION that fail pureCheck for any reason
• and for those that fail pureCheck because they don't even have the intrinsic gas amount
• and for Type 3 format (BLOB) Ethereum transactions (that we don't support)

Related issue(s):

Fixes #16076

Notes for reviewer:

• Key class is ContractMetrics to encapsulate all SCSC metrics; and currently it is used in ContractCreateHandler, ContractCallHandler, and EthereumTransactionHandler
• Added a Supplier<Metrics> to the AppContext so smart contract service (and others) can get the metrics instance from the app.
  • There are quite a few unit tests that needed to be modified for this change as they create an AppContext out of thin air
  • This may not be necessary. I was unable to inject a Metrics object where needed but apparently token service can in CryptoGetAccountBalanceHandler - I need to find out how
  • Plus it is somewhat awkward as the AppContext is created before the Metrics instance is gotten from the platform
  • And this is why I have a locked "once only" method to initialize ContractMetrics - I'll be asking people about how to do that better as well

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[andrewb1269hg]

Reviewed the following file:
hedera-node/hedera-smart-contract-service-impl/src/main/java/module-info.java

[andrewb1269hg]

Reviewed the following files:
hedera-node/hedera-app-spi/src/main/java/module-info.java
hedera-node/hedera-smart-contract-service-impl/src/main/java/module-info.java

These two files look good.

[david-bakin-sl]

Switching to draft until (extensive) rebase is confirmed.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -1.00%)	✅ 84.21%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (98c37b9)	97773	63984	65.44%
Head commit (6009a60)	97882 (+109)	64065 (+81)	65.45% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#16077)	152	128	84.21%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[codecov]

Codecov Report

Attention: Patch coverage is 80.92105% with 29 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (c0dfdfc) to head (6009a60).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ce/contract/impl/exec/metrics/ContractMetrics.java	82.75%	14 Missing and 1 partial ⚠️
...ract/impl/handlers/EthereumTransactionHandler.java	62.50%	3 Missing and 3 partials ⚠️
...app/service/contract/impl/ContractServiceImpl.java	50.00%	3 Missing ⚠️
...-app/src/main/java/com/hedera/node/app/Hedera.java	0.00%	2 Missing ⚠️
...l/handlers/AbstractContractTransactionHandler.java	88.88%	1 Missing and 1 partial ⚠️
...app/workflows/standalone/TransactionExecutors.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             develop   #16077    +/-   ##
===========================================
  Coverage      63.74%   63.74%            
- Complexity     20493    20511    +18     
===========================================
  Files           2538     2540     +2     
  Lines          95008    95117   +109     
  Branches        9931     9937     +6     
===========================================
+ Hits           60559    60636    +77     
- Misses         30834    30862    +28     
- Partials        3615     3619     +4     

Files with missing lines	Coverage Δ
.../main/java/com/hedera/node/app/spi/AppContext.java	33.33% <ø> (ø)
...a/com/hedera/node/app/services/AppContextImpl.java	100.00% <ø> (ø)
...a/com/hedera/node/config/data/ContractsConfig.java	100.00% <ø> (ø)
...ce/contract/impl/handlers/ContractCallHandler.java	100.00% <100.00%> (ø)
.../contract/impl/handlers/ContractCreateHandler.java	100.00% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java	91.07% <66.66%> (-1.53%)	⬇️
...-app/src/main/java/com/hedera/node/app/Hedera.java	56.79% <0.00%> (-0.32%)	⬇️
...l/handlers/AbstractContractTransactionHandler.java	88.88% <88.88%> (ø)
...app/service/contract/impl/ContractServiceImpl.java	85.00% <50.00%> (-15.00%)	⬇️
...ract/impl/handlers/EthereumTransactionHandler.java	77.46% <62.50%> (-3.14%)	⬇️
... and 1 more

... and 4 files with indirect coverage changes

[andrewb1269hg]

Review applies to:
hedera-node/hedera-smart-contract-service-impl/src/main/java/module-info.java

Approved.

[lukelee-sl]

LGTM