Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry pick smart contract service P1 metrics to release 0.57 #16881

Merged

Conversation

david-bakin-sl
Copy link
Member

Cherry pick of #16077 (from the PR, which has not yet merged to develop)

Related issue(s):

Fixes #16076

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Cherry pick of #16077 (from the PR, which has not yet merged to develop)

Signed-off-by: David S Bakin <[email protected]>
@david-bakin-sl david-bakin-sl added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Dec 3, 2024
@david-bakin-sl david-bakin-sl added this to the v0.57 milestone Dec 3, 2024
@david-bakin-sl david-bakin-sl self-assigned this Dec 3, 2024
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 84.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d40150f) 97822 63925 65.35%
Head commit (fa1b818) 97931 (+109) 64011 (+86) 65.36% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16881) 151 127 84.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @david-bakin-sl

@iwsimon iwsimon merged commit 5744bd3 into release/0.57 Dec 3, 2024
67 of 68 checks passed
@iwsimon iwsimon deleted the 0.57-cherrypick-of-16076-scsc-metrics-purecheck branch December 3, 2024 21:57
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (d40150f) to head (fa1b818).
Report is 1 commits behind head on release/0.57.

Files with missing lines Patch % Lines
...ce/contract/impl/exec/metrics/ContractMetrics.java 82.75% 14 Missing and 1 partial ⚠️
...ract/impl/handlers/EthereumTransactionHandler.java 62.50% 3 Missing and 3 partials ⚠️
...app/service/contract/impl/ContractServiceImpl.java 50.00% 3 Missing ⚠️
...-app/src/main/java/com/hedera/node/app/Hedera.java 0.00% 2 Missing ⚠️
...l/handlers/AbstractContractTransactionHandler.java 88.88% 1 Missing and 1 partial ⚠️
...app/workflows/standalone/TransactionExecutors.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.57   #16881      +/-   ##
==================================================
+ Coverage           63.63%   63.65%   +0.01%     
- Complexity          20447    20473      +26     
==================================================
  Files                2547     2549       +2     
  Lines               95057    95166     +109     
  Branches             9933     9939       +6     
==================================================
+ Hits                60491    60574      +83     
- Misses              30943    30966      +23     
- Partials             3623     3626       +3     
Files with missing lines Coverage Δ
.../main/java/com/hedera/node/app/spi/AppContext.java 33.33% <ø> (ø)
...a/com/hedera/node/app/services/AppContextImpl.java 100.00% <ø> (ø)
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...ce/contract/impl/handlers/ContractCallHandler.java 100.00% <100.00%> (ø)
.../contract/impl/handlers/ContractCreateHandler.java 100.00% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java 91.07% <50.00%> (-1.53%) ⬇️
...-app/src/main/java/com/hedera/node/app/Hedera.java 56.79% <0.00%> (-0.32%) ⬇️
...l/handlers/AbstractContractTransactionHandler.java 88.88% <88.88%> (ø)
...app/service/contract/impl/ContractServiceImpl.java 85.00% <50.00%> (-15.00%) ⬇️
...ract/impl/handlers/EthereumTransactionHandler.java 77.46% <62.50%> (-3.14%) ⬇️
... and 1 more

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants