Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid type for amount in wipeTokenAccount function argument #85

Closed
Shungy opened this issue Oct 7, 2022 · 4 comments
Closed

Invalid type for amount in wipeTokenAccount function argument #85

Shungy opened this issue Oct 7, 2022 · 4 comments
Assignees
@georgi-l95
Labels
Limechain Items for Limechain team
Milestone
0.3.0

Comments

@Shungy
Copy link

Shungy commented Oct 7, 2022

hedera-smart-contracts/contracts/hts-precompile/HederaTokenService.sol

Line 520 in 30404a3

function wipeTokenAccount(address token, address account, uint32 amount) internal returns (int responseCode)

It should be uint64, not uint32.
@Shungy Shungy changed the title Invalid type for amoun in wipeTokenAccount function argument Invalid type for amount in wipeTokenAccount function argument Oct 7, 2022
@Nana-EC Nana-EC added the Limechain Items for Limechain team label Oct 15, 2022
@Nana-EC
Copy link
Collaborator

Nana-EC commented Oct 15, 2022

@georgi-l95 let's see if this impacts #99

@Nana-EC Nana-EC added this to the 0.3.0 milestone Oct 15, 2022
@Nana-EC Nana-EC moved this to Sprint BackLog in Smart Contract Sprint Board Oct 17, 2022
@georgi-l95
Copy link
Contributor

It makes sense to be uint64 and maybe we should change it with PR #99 from uint32 to int64, but that means that we have to change it in services and in docs as well.

@dimitrovmaksim dimitrovmaksim mentioned this issue Oct 17, 2022
Merged
2 tasks
@georg-getz georg-getz mentioned this issue Oct 20, 2022
Closed
2 tasks
@georgi-l95
Copy link
Contributor

Resolved in services repo. Will be resolved here as well in PR #99 .

@Shungy Shungy mentioned this issue Nov 22, 2022
Closed
@Kalina-Todorova Kalina-Todorova moved this from Sprint BackLog to In Progress in Smart Contract Sprint Board Nov 23, 2022
@georg-getz georg-getz mentioned this issue Dec 12, 2022
Merged
@georgi-l95
Copy link
Contributor

Fixed in #151

Repository owner moved this from In Progress to Done in Smart Contract Sprint Board Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgi-l95 georgi-l95

Labels
Limechain Items for Limechain team
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@georgi-l95 @Shungy @Nana-EC