Refactor example token contracts #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
georgi-l95
added
enhancement
georgi-l95
requested review from
Ivo-Yankov,
natanasow,
dimitrovmaksim and
Nana-EC
17 tasks
contracts/hts-precompile/examples/token-create/TokenCreateContract.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Nana-EC
requested changes
Oct 17, 2022
contracts/hts-precompile/examples/token-transfer/TokenTransferContract.sol
Outdated
Show resolved
Hide resolved
contracts/hts-precompile/examples/token-transfer/TokenTransferContract.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: georgi-l95 <[email protected]>
georg-getz
pushed a commit
to georg-getz/hedera-smart-contracts
that referenced
this pull request
Dec 12, 2022
* TokenQueryContract.sol ready Signed-off-by: georgi-l95 <[email protected]> * add transferFrom and tranferFromNFT to HTS Signed-off-by: georgi-l95 <[email protected]> * TokenTransferContract.sol ready Signed-off-by: georgi-l95 <[email protected]> * TokenManagementContract.sol ready Signed-off-by: georgi-l95 <[email protected]> * TokenCreateContract.sol ready Signed-off-by: georgi-l95 <[email protected]> * delete TokenCreate.sol Signed-off-by: georgi-l95 <[email protected]> * fix tests Signed-off-by: georgi-l95 <[email protected]> * fixed empty lines Signed-off-by: georgi-l95 <[email protected]> * fix tests Signed-off-by: georgi-l95 <[email protected]> * x Signed-off-by: georgi-l95 <[email protected]> * x Signed-off-by: georgi-l95 <[email protected]> * fix test Signed-off-by: georgi-l95 <[email protected]> * address comments Signed-off-by: georgi-l95 <[email protected]> Signed-off-by: georgi-l95 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor example contracts, so that each contract is responsible for one type of operations.
Apply those changes in the tests.
Related issue(s):
Fixes #109
Fixes #110
Fixes #111
Fixes #112
Notes for reviewer:
Checklist