Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider adding repo maintainers to the CODEOWNERS and LICENSE files #332

Closed
andrewb1269hg opened this issue Nov 22, 2024 · 2 comments · Fixed by #333
Closed

consider adding repo maintainers to the CODEOWNERS and LICENSE files #332

andrewb1269hg opened this issue Nov 22, 2024 · 2 comments · Fixed by #333
Assignees
@rbarkerSL @andrewb1269hg
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@andrewb1269hg
Copy link
Contributor

andrewb1269hg commented Nov 22, 2024 •
edited
Loading

Per Richard, we should discuss adding the repo maintainer group (in this case, pbj-maintainers) to the CODEOWNERS file and LICENSE file of the repo. This will allow the maintainers to make any modifications required without having to go through another team.
@andrewb1269hg andrewb1269hg added the github_actions Pull requests that update GitHub Actions code label Nov 22, 2024
@rbarkerSL
Copy link
Contributor

We should not update the CODEOWNERS line. That's a catch in case that file is ever created.

LICENSE and .github folder should be considered.

@andrewb1269hg
Copy link
Contributor Author

The .github folder is already updated to include the pbj-maintainers so we will discuss adding the maintainers to License.

andrewb1269hg added a commit that referenced this issue Nov 26, 2024
@andrewb1269hg
chore: add pbj-maintainers to License file in CODEOWNERS
730641a 
**Description**:

The purpose of this change is to add the pbj-maintainers group to the License file as defined in the CODEOWNERS file.

**Related Issue(s)**:

Fixes #332

Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg andrewb1269hg mentioned this issue Nov 26, 2024
Merged
2 tasks
@andrewb1269hg andrewb1269hg linked a pull request Nov 26, 2024 that will close this issue
chore: add pbj-maintainers to License file in CODEOWNERS #333
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbarkerSL rbarkerSL

@andrewb1269hg andrewb1269hg

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add pbj-maintainers to License file in CODEOWNERS hashgraph/pbj
2 participants
@rbarkerSL @andrewb1269hg