Skip to content

fix: Fix handling of generated files for Comparable verification

Codacy Production / Codacy Static Code Analysis required action Jan 30, 2024 in 0s

11 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 9
- Added 11
           

Complexity increasing per file
==============================
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/TimestampTestTest.java  1
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/integration/jmh/EqualsHashCodeBench.java  2
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/integration/jmh/JsonBench.java  3
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/CompareToNegativeTest.java  1
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/JsonCodecTest.java  1
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/integration/jmh/VarIntBench.java  8
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/MalformedMessageTest.java  1
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/integration/jmh/ComplexEqualsHashCodeBench.java  2
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/BytesNonNullTest.java  1
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/TestHashFunctions.java  23
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/integration/jmh/ProtobufObjectBench.java  3
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/TruncatedDataTests.java  1
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/integration/jmh/HashBench.java  2
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/HashEqualsTest.java  1
- pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/CompareToTest.java  2
         

See the complete overview on Codacy

Annotations

Check notice on line 36 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L36

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 42 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L42

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 44 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L44

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 45 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L45

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 47 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L47

'VARIABLE_DEF' should be separated from previous line.

Check warning on line 272 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L272

Avoid throwing raw exception types.

Check notice on line 606 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L606

Line is longer than 120 characters (found 136).

Check notice on line 749 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L749

Line is longer than 120 characters (found 123).

Check notice on line 755 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L755

Line is longer than 120 characters (found 121).

Check notice on line 768 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L768

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 769 in pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/impl/Common.java#L769

'VARIABLE_DEF' should be separated from previous line.