From ad8da28fd1d70c5656d4516978b1b8e25113270f Mon Sep 17 00:00:00 2001
From: Jeff Daley <jeffdaley@users.noreply.github.com>
Date: Wed, 6 Mar 2024 20:43:42 -0500
Subject: [PATCH] Tweak sidebar footer CSS

---
 web/app/components/document/sidebar.hbs | 70 +++++++++++++------------
 web/app/styles/components/sidebar.scss  |  4 --
 2 files changed, 36 insertions(+), 38 deletions(-)

diff --git a/web/app/components/document/sidebar.hbs b/web/app/components/document/sidebar.hbs
index 2e952e837..446c5e624 100644
--- a/web/app/components/document/sidebar.hbs
+++ b/web/app/components/document/sidebar.hbs
@@ -405,45 +405,47 @@
   {{#if this.footerIsShown}}
     <div
       data-test-sidebar-footer
-      class="sidebar-footer {{if this.editingIsDisabled 'locked'}}"
+      class="sidebar-footer
+        {{if
+          this.footerControlsAreDisabled
+          'border-t border-t-color-border-primary'
+        }}"
     >
       {{#if this.footerControlsAreDisabled}}
         {{! Disabled controls }}
-        <div class="-mb-1 px-3">
-          <div class="w-full border-t border-color-border-primary pt-3.5">
-            <div class="text-body-200 text-color-foreground-faint">
-              <h5
-                data-test-disabled-footer-h5
-                class="mb-1 flex items-center text-body-200 font-semibold text-color-foreground-primary"
-              >
-                {{if this.docIsLocked "Document is locked" "Read-only headers"}}
-                <FlightIcon
-                  @name="lock"
-                  class="-mt-px ml-1.5 shrink-0 text-color-foreground-faint"
-                />
-              </h5>
-              <p class="mb-1.5">
-                {{if
-                  this.docIsLocked
-                  "Due to a Google API bug, all suggestions must be removed from the document header to unlock."
-                  "Weʼre unable to edit the metadata of files created offsite."
-                }}
-              </p>
-            </div>
-            {{#if this.docIsLocked}}
-              <Hds::Link::Standalone
-                @icon="arrow-right"
-                @iconPosition="trailing"
-                @text="See the issue on GitHub"
-                @size="small"
-                @href="https://github.com/hashicorp-forge/hermes/issues/181"
+        <div class="-mb-1 -mt-0.5 px-3">
+          <div class="text-body-200 text-color-foreground-faint">
+            <h5
+              data-test-disabled-footer-h5
+              class="mb-1 flex items-center text-body-200 font-semibold text-color-foreground-primary"
+            >
+              {{if this.docIsLocked "Document is locked" "Read-only headers"}}
+              <FlightIcon
+                @name="lock"
+                class="-mt-px ml-1.5 shrink-0 text-color-foreground-faint"
               />
-            {{else}}
-              <div class="text-body-100 text-color-foreground-faint">
-                Create docs in-app for best results.
-              </div>
-            {{/if}}
+            </h5>
+            <p class="mb-1.5">
+              {{if
+                this.docIsLocked
+                "Due to a Google API bug, all suggestions must be removed from the document header to unlock."
+                "Weʼre unable to edit the metadata of files created offsite."
+              }}
+            </p>
           </div>
+          {{#if this.docIsLocked}}
+            <Hds::Link::Standalone
+              @icon="arrow-right"
+              @iconPosition="trailing"
+              @text="See the issue on GitHub"
+              @size="small"
+              @href="https://github.com/hashicorp-forge/hermes/issues/181"
+            />
+          {{else}}
+            <div class="text-body-100 text-color-foreground-faint">
+              Create docs in-app for best results.
+            </div>
+          {{/if}}
         </div>
       {{else}}
         {{#let (and this.isDraft this.isOwner) as |canPublish|}}
diff --git a/web/app/styles/components/sidebar.scss b/web/app/styles/components/sidebar.scss
index 63ea0ad92..d1ecaf1f0 100644
--- a/web/app/styles/components/sidebar.scss
+++ b/web/app/styles/components/sidebar.scss
@@ -168,9 +168,5 @@
 
   .sidebar-footer {
     @apply w-full shrink-0 bg-color-page-faint py-4 px-3.5;
-
-    &.locked {
-      @apply pt-0;
-    }
   }
 }