Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update the security-scanner gha token #619

Merged
merged 1 commit into from
Sep 17, 2024
Merged

ci: update the security-scanner gha token #619

merged 1 commit into from
Sep 17, 2024

Conversation

dduzgun-security
Copy link
Contributor

Description

Using the org level secret instead of the repository one and removing conditional check to use paths-ignore.

Testing & Reproduction steps

If the security scan passes, we are good.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@dduzgun-security dduzgun-security added pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog backport/1.1 Changes are backported to 1.1 backport/1.3 Changes are backported to 1.3 backport/1.4 Changes are backported to 1.4 backport/1.5 Changes are backported to 1.5 labels Sep 17, 2024
@dduzgun-security dduzgun-security requested a review from a team as a code owner September 17, 2024 00:30
@dduzgun-security dduzgun-security merged commit c9ea7d4 into main Sep 17, 2024
52 checks passed
@dduzgun-security dduzgun-security deleted the ci/update-security-scanner-token branch September 17, 2024 15:01
This was referenced Sep 17, 2024
Merged
Merged
Merged
Merged
@dduzgun-security
Copy link
Contributor Author

@zalimeni & @sarahalsmiller looks like the backport is failing due to the CLA check for the temp GitHub user, any ideas on how to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@sarahalsmiller sarahalsmiller Awaiting requested review from sarahalsmiller

Assignees
No one assigned
Labels
backport/1.1 Changes are backported to 1.1 backport/1.3 Changes are backported to 1.3 backport/1.4 Changes are backported to 1.4 backport/1.5 Changes are backported to 1.5 pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dduzgun-security @zalimeni