New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/WAF: failure zones refresh #21545

Merged

krastin merged 12 commits into main from docs/WAF-73-Failure-Zones

Jul 22, 2024

Contributor

krastin commented Jul 15, 2024

Description

Incorporating some WAF content into the related Consul doc.

Testing & Reproduction steps

N/A

Links

N/A

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern


          failure zones initial commit

59949cc

krastin requested a review from a team as a code owner

July 15, 2024 14:35

github-actions bot added the type/docs label

krastin added pr/no-changelog backport/all labels


          Merge branch 'main' into docs/WAF-73-Failure-Zones

9e03985

cjobermaier reviewed

View reviewed changes

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

aimeeu approved these changes

View reviewed changes

Contributor

aimeeu left a comment

nits, and some structure suggestions

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

cjobermaier approved these changes

View reviewed changes

danielehc approved these changes

View reviewed changes

Contributor

danielehc left a comment

Thank for revamping this.

Left a few comments.

The only thing I would add for some of these sections would be an architectural diagram that explains the desired architecture.

i.e.

for redundancy zones something like the one in https://developer.hashicorp.com/consul/tutorials/operate-consul/redundancy-zones or the one present in the reference architecture https://developer.hashicorp.com/consul/tutorials/production-vms/reference-architecture#enterprise-feature-redundancy-zones
for cluster peering something similar to the one in https://developer.hashicorp.com/consul/tutorials/implement-multi-tenancy/cluster-peering#scenario-overview but with the same services present in both DCs

This would make it easier to follow the failure cases listed as examples

danielehc reviewed

View reviewed changes

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved


          Apply suggestions from code review

06ace24

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

vercel bot deployed to Preview – consul

July 17, 2024 15:37

View deployment


          Update improving-consul-resilience.mdx

6a2e448

Co-authored-by: Aimee Ukasick <[email protected]>

krastin added the pr/no-metrics-test label

vercel bot deployed to Preview – consul

July 17, 2024 15:45

View deployment

krastin changed the title ~~failure zones initial commit~~ docs/WAF: failure zones refresh


          typo

9e210fc

vercel bot deployed to Preview – consul

July 17, 2024 16:15

View deployment


          adding diagrams

5cad417

vercel bot deployed to Preview – consul

July 17, 2024 16:29

View deployment


          fixing inline bulletpoint image

111c1d1

vercel bot deployed to Preview – consul

July 17, 2024 16:40

View deployment

boruszak reviewed

View reviewed changes

Contributor

boruszak left a comment

Style changes and simplifications.

Before merging, we still need:

Dark mode images
Links to tutorials like the redundancy zones tutorial, because they demonstrate these concepts with a practical example.

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated


		Cluster peering lets you connect two or more independent Consul clusters using mesh gateways, so that services can communicate between non-identical partitions in different datacenters.

		![Reference architecture diagram for Consul cluster peering](/img/architecture/cluster-peering-diagram.png)

Contributor

boruszak Jul 17, 2024

Dark mode required

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

website/content/docs/architecture/improving-consul-resilience.mdx Outdated Show resolved Hide resolved

krastin and others added 3 commits

July 22, 2024 13:47


          adding light and dark diagrams

7bdfe9e


          Apply suggestions from code review

11bf8c6

Co-authored-by: Jeff Boruszak <[email protected]>


          Merge branch 'main' into docs/WAF-73-Failure-Zones

c294942

vercel bot deployed to Preview – consul

July 22, 2024 12:00

View deployment


          fix links in article

389d5ec

vercel bot deployed to Preview – consul

July 22, 2024 13:26

View deployment

Collaborator

hc-github-team-consul-core commented Aug 7, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.16,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 8, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

16 similar comments

Collaborator

hc-github-team-consul-core commented Aug 9, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 10, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 11, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 12, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 13, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 14, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 15, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 16, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 17, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 18, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 19, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 19, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 20, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 21, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 22, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 23, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

boruszak added a commit that referenced this pull request


          docs/WAF: failure zones refresh (#21545)

7640c2a

* failure zones initial commit

* Apply suggestions from code review

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

* Update improving-consul-resilience.mdx

Co-authored-by: Aimee Ukasick <[email protected]>

* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <[email protected]>

* fix links in article

* fix inline alert render

---------

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>

boruszak added a commit that referenced this pull request


          docs/WAF: failure zones refresh (#21545)

f97e8cf

* failure zones initial commit

* Apply suggestions from code review

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

* Update improving-consul-resilience.mdx

Co-authored-by: Aimee Ukasick <[email protected]>

* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <[email protected]>

* fix links in article

* fix inline alert render

---------

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>

boruszak added a commit that referenced this pull request


          docs/WAF: failure zones refresh (#21545)

bf50429

* failure zones initial commit

* Apply suggestions from code review

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

* Update improving-consul-resilience.mdx

Co-authored-by: Aimee Ukasick <[email protected]>

* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <[email protected]>

* fix links in article

* fix inline alert render

---------

Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>

Collaborator

hc-github-team-consul-core commented Aug 24, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments

Collaborator

hc-github-team-consul-core commented Aug 25, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Aug 26, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

boruszak added a commit that referenced this pull request


          docs/WAF: failure zones refresh v1.15 manual backport (#21545) (#21653)

7ee99ca

docs/WAF: failure zones refresh (#21545)

* failure zones initial commit

* Apply suggestions from code review




* Update improving-consul-resilience.mdx



* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review



* fix links in article

* fix inline alert render

---------

Co-authored-by: Krastin Krastev <[email protected]>
Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

boruszak added a commit that referenced this pull request


          docs/WAF: failure zones refresh (#21545) (#21652)

* failure zones initial commit

* Apply suggestions from code review




* Update improving-consul-resilience.mdx



* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review



* fix links in article

* fix inline alert render

---------

Co-authored-by: Krastin Krastev <[email protected]>
Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

boruszak added a commit that referenced this pull request


          Manual backport for docs/WAF: failure zones refresh (#21545) (#21651)

e7d651b

docs/WAF: failure zones refresh (#21545)

* failure zones initial commit

* Apply suggestions from code review




* Update improving-consul-resilience.mdx



* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review



* fix links in article

* fix inline alert render

---------

Co-authored-by: Krastin Krastev <[email protected]>
Co-authored-by: Aimee Ukasick <[email protected]>
Co-authored-by: danielehc <[email protected]>

Collaborator

hc-github-team-consul-core commented Aug 27, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment

Collaborator

hc-github-team-consul-core commented Aug 28, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

dhiaayachi mentioned this pull request

Backport of docs/WAF: failure zones refresh into release/1.19.x dhiaayachi/consul#251

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/all backport/ent/1.15 backport/ent/1.17 backport/ent/1.18 backport/1.19 pr/no-changelog pr/no-metrics-test type/docs