Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time. #21609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gents the minimal amount of time
jmurret
added
pr/no-changelog
zalimeni
approved these changes
Aug 15, 2024
jmurret
added a commit
that referenced
this pull request
Aug 15, 2024
…agents the minimal amount of time (#21608) * get rid of unused column * get rid of duplicate section now that deletion of unused column makes the section duplicate.. * explicit set protocol rathern than infer it in checkDNSService * explicit have attribute for whether to set EDNS0 in the test cases rathern than infer it in checkDNSService * now modify so that test agents are only created for each unique configuration which is based on the a_record_limit. * Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time. (#21609) Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time
|
@jmurret, a backport is missing for this PR [21609] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description: |
3 similar comments
|
@jmurret, a backport is missing for this PR [21609] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description: |
|
@jmurret, a backport is missing for this PR [21609] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description: |
|
@jmurret, a backport is missing for this PR [21609] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description: |
jmurret
removed
the
backport/1.19
philrenaud
pushed a commit
that referenced
this pull request
Sep 12, 2024
…agents the minimal amount of time (#21608) * get rid of unused column * get rid of duplicate section now that deletion of unused column makes the section duplicate.. * explicit set protocol rathern than infer it in checkDNSService * explicit have attribute for whether to set EDNS0 in the test cases rathern than infer it in checkDNSService * now modify so that test agents are only created for each unique configuration which is based on the a_record_limit. * Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time. (#21609) Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes a similar approach as #21608 and reduces 36 created test agents down to 12. This reduces local runtime from 61 seconds to 20 secs.
PR Checklist