Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to go-difflib and go-spew releases #21234

Closed
wants to merge 1 commit into from

Conversation

skitt
Copy link

@skitt skitt commented May 29, 2024

Description

In both go-difflib and go-spew, the changes since the last release are insignificant (only touching documentation or CI):

This reverts the dependencies to the last release, as far as possible, in MPL-2.0-licensed components.

Testing & Reproduction steps

Nothing special.

Links

kubernetes/kubernetes#123339

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@skitt skitt requested a review from a team as a code owner May 29, 2024 09:44
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label May 29, 2024
In both go-difflib and go-spew, the changes since the last release are
insignificant (only touching documentation or CI):

* pmezard/go-difflib@v1.0.0...master
* davecgh/go-spew@v1.1.1...master

This reverts the dependencies to the last release, as far as possible,
in MPL-2.0-licensed components.

See also the discussion in
kubernetes/kubernetes#123339

Signed-off-by: Stephen Kitt <[email protected]>
@skitt skitt force-pushed the revert-go-difflib-go-spew branch from 19c3461 to 74ca182 Compare May 29, 2024 12:09
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Aug 19, 2024
@skitt skitt closed this Aug 19, 2024
@skitt skitt deleted the revert-go-difflib-go-spew branch August 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot theme/api Relating to the HTTP API interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant