Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-1.18.4 - update changelog and version in 1.18.x #21678

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Aug 28, 2024

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Aug 28, 2024
@jmurret jmurret changed the title update changelog to include 1.18.4 post-1.18.4 - update changelog and version in 1.18.x Aug 28, 2024
Copy link
Contributor

@NicoletaPopoviciu NicoletaPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for capturing the 1.18.3 changes as well; looks like the version update was missed during the last patch release.

Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace edits, otherwise 👍🏻

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@@ -1 +1 @@
1.18.3-dev
1.18.5-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof.

Co-authored-by: Michael Zalimeni <[email protected]>
@jmurret jmurret enabled auto-merge (squash) August 28, 2024 15:46
@jmurret jmurret merged commit 5a37661 into release/1.18.x Aug 28, 2024
84 checks passed
@jmurret jmurret deleted the jm/post-1.18.4 branch August 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants