Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable auto scaling group health check #273

Closed
sudomateo opened this issue Nov 21, 2022 · 1 comment · Fixed by #326
Closed

Configurable auto scaling group health check #273

sudomateo opened this issue Nov 21, 2022 · 1 comment · Fixed by #326
Labels
enhancement New feature or request

Comments

@sudomateo
Copy link
Contributor

What problem would you like to address?

Support a configurable health check for the auto scaling group. The current settings are too aggressive and cause the instance to terminate during an upgrade.

  • Add support for configuring the health_check_grace_period.
  • Add support for configuring the health_check_type.

Who is the audience for this request?

Everyone.

What would the ideal solution look like?

Expose variable to configure the aforementioned settings.

What alternatives have you considered?

Using Azure and GCP.

How does this impact you?

It making doing automated upgrade testing difficult.

Are there any deadlines?

N/A

Is there any additional context?

N/A
@sudomateo sudomateo added the enhancement New feature or request label Nov 21, 2022
@anniehedgpeth
Copy link
Contributor

Note for Jira: I would prioritize this due to it complicating our release testing process.

@sudomateo sudomateo mentioned this issue Mar 28, 2024
Merged
miguelhrocha pushed a commit that referenced this issue Mar 28, 2024
@sudomateo
feat: configurable health_check_type (#326)
502a93d 
This patch adds support for configuring the `health_check_type` of the
underlying instance managed by the auto scaling group. This allows
operators to switch from the comprehensive `ELB` check to a simpler
`EC2` check to prevent the instance from being recycled during upgrades.

Resolves #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: configurable health_check_type
2 participants
@anniehedgpeth @sudomateo