[TF-10414] Upgrade modules to AWS V5 provider

[miguelhrocha]

Background

Some of the AWS APIs supported in V4 are going to get deprecated by EOY. Not to mention that some flaky situations have been spotted during the execution of modules relying on V4, which have been addressed on V5.

This PR upgrades the version constraints of the modules to rely on the AWS V5 provider.

Relates OR Closes #0000

How Has This Been Tested

I ran terraform init in each submodule to verify this is not introducing breaking syntax.

[miguelhrocha]

/test all destroy=true

❌ Terraform AWS Public Active/Active (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ❌ Terraform Apply

• ❌ Run k6 Smoke Test

• ✅ Terraform Destroy

✅ Terraform AWS Private Active/Active (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

• ✅ Terraform Destroy

✅ Terraform AWS Active/Active RHEL7 Proxy (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

• ✅ Terraform Destroy

❌ Terraform AWS Private TCP Active/Active (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

• ✅ Terraform Destroy

✅ Terraform AWS Public Active/Active (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

• ✅ Terraform Destroy

✅ Terraform AWS Private Active/Active (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

• ✅ Terraform Destroy

❌ Terraform AWS Private TCP Active/Active (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

• ✅ Terraform Destroy

✅ Terraform AWS Standalone Vault (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

• ✅ Terraform Destroy

✅ Terraform AWS Standalone Vault (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

• ✅ Terraform Destroy

❌ Terraform AWS Active/Active RHEL7 Proxy (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

• ✅ Terraform Destroy

[anniehedgpeth]

/test public-active-active-replicated destroy=false

✅ Terraform AWS Public Active/Active (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ✅ Run k6 Smoke Test

[anniehedgpeth]

/test private-tcp-active-active destroy=false

❌ Terraform AWS Private TCP Active/Active (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

❌ Terraform AWS Private TCP Active/Active (FDO) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

[anniehedgpeth]

/test private-tcp-active-active-replicated destroy=false

❌ Terraform AWS Private TCP Active/Active (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

[anniehedgpeth]

/test active-active-rhel7-proxy-replicated destroy=false

❌ Terraform AWS Active/Active RHEL7 Proxy (Legacy) - Test Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Validate

• ✅ Terraform Apply

• ❌ Run k6 Smoke Test

[anniehedgpeth]

The failing tests appear to be the result of cloud resource errors and replicated.com needing to be added to the no_proxy list, not due to any changes in this PR. A follow up PR will be made to address the failures.

[anniehedgpeth]

/destroy active-active-rhel7-proxy-replicated

✅ Terraform AWS Active/Active RHEL7 Proxy (Replicated) - Destruction Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Destroy

[anniehedgpeth]

/destroy private-tcp-active-active-replicated

✅ Terraform AWS Private TCP Active/Active (Replicated) - Destruction Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Destroy

[anniehedgpeth]

/destroy private-tcp-active-active

✅ Terraform AWS Private TCP Active/Active (FDO) - Destruction Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Destroy

[anniehedgpeth]

/destroy public-active-active-replicated

✅ Terraform AWS Public Active/Active (Replicated) - Destruction Report

🔗 Action Summary Page

• ✅ Terraform Init

• ✅ Terraform Destroy