Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-1326 consolidated testing & add metrics #214

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented May 4, 2023

Background

When testing /metrics in TF-5770, I discovered that this module lacks the proper networking to allow the metrics ports to be reached.

How Has This Been Tested

I ran the standalone-external and standalone-mounted-disk tests locally and was able to see metrics at $TFE_URL:9091/metrics?format=prometheus.

I will also run tests in the comments.

Annie Hedgpeth added 4 commits May 2, 2023 14:37
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner May 4, 2023 22:41
theoskolnik
theoskolnik previously approved these changes May 4, 2023
Copy link
Contributor

@theoskolnik theoskolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ I also used these changes and tested that they do indeed work. Thanks Annie!

@@ -4,7 +4,7 @@
resource "random_string" "friendly_name" {
length = 4
upper = false
number = false
numeric = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that.

Copy link
Contributor

@p0pr0ck5 p0pr0ck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the smell of terraform in the morning!

p0pr0ck5
p0pr0ck5 previously approved these changes May 4, 2023
@anniehedgpeth anniehedgpeth dismissed stale reviews from p0pr0ck5 and theoskolnik via 7b7c27b May 5, 2023 17:28
@anniehedgpeth anniehedgpeth marked this pull request as draft May 5, 2023 22:57
@anniehedgpeth
Copy link
Contributor Author

Sorry for the test noise! I'm moving this into draft while I sort out the proxy config. This turned out to be bigger than I had thought.

@anniehedgpeth anniehedgpeth changed the title TF-1326 consolidated testing TF-1326 consolidated testing & add metrics Aug 30, 2023
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 6, 2023

/test all

✅ Terraform Azure Standalone Mounted Disk Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

❌ Terraform Azure Standalone External Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ❌ Terraform Destroy

✅ Terraform Azure Public Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

/destroy standalone-external

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 6, 2023

/destroy azure-standalone-external

✅ Terraform Azure Standalone External Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 6, 2023

/test private-active-active destroy=false

  • updated the bastion private key in repo secrets

✅ Terraform Azure Private Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 6, 2023

/destroy private-active-active

✅ Terraform Azure Private Active/Active Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

Tests for private-tcp-active-active passed on main here, so I'll need to rework the networking for application gateway for this branch.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 8, 2024

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Annie Hedgpeth seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@nikolasrieble
Copy link
Contributor

/destroy all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants