-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-1326 consolidated testing & add metrics #214
base: main
Are you sure you want to change the base?
Conversation
* add consolidate_services var to tests * fmt fmt WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ I also used these changes and tested that they do indeed work. Thanks Annie!
@@ -4,7 +4,7 @@ | |||
resource "random_string" "friendly_name" { | |||
length = 4 | |||
upper = false | |||
number = false | |||
numeric = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the smell of terraform in the morning!
Sorry for the test noise! I'm moving this into draft while I sort out the proxy config. This turned out to be bigger than I had thought. |
/test all ✅ Terraform Azure Standalone Mounted Disk Test Report
❌ Terraform Azure Standalone External Test Report
✅ Terraform Azure Public Active/Active Test Report
|
/destroy standalone-external |
/destroy azure-standalone-external ✅ Terraform Azure Standalone External Destruction Report
|
/test private-active-active destroy=false
✅ Terraform Azure Private Active/Active Test Report
|
/destroy private-active-active ✅ Terraform Azure Private Active/Active Destruction Report
|
Tests for |
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Annie Hedgpeth seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
/destroy all |
Background
When testing
/metrics
in TF-5770, I discovered that this module lacks the proper networking to allow the metrics ports to be reached.How Has This Been Tested
I ran the
standalone-external
andstandalone-mounted-disk
tests locally and was able to see metrics at$TFE_URL:9091/metrics?format=prometheus
.I will also run tests in the comments.