Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disk path to docker compose #242

Merged
merged 3 commits into from
Nov 15, 2023
Merged

add disk path to docker compose #242

merged 3 commits into from
Nov 15, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Nov 15, 2023

Background

Relates: hashicorp/terraform-random-tfe-utility#135

While testing a backup, @miguelhrocha discovered that the disk_path was not set for FDO deployments. It had gone unnoticed since we had not done a backup test yet using these modules as it was using the default docker mount.

How Has This Been Tested

Passing test below. Also, here you can see that the postgres data is on the instance.

Screenshot 2023-11-15 at 10 28 34 AM

@anniehedgpeth anniehedgpeth changed the title Ah/disk path add disk path to docker compose Nov 15, 2023
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023

/test standalone-mounted-disk destroy=false

✅ Terraform Azure Standalone Mounted Disk (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 15, 2023

/destroy standalone-mounted-disk

✅ Terraform Azure Standalone Mounted Disk (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth anniehedgpeth marked this pull request as ready for review November 15, 2023 17:40
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner November 15, 2023 17:40
@anniehedgpeth anniehedgpeth merged commit 560fe25 into main Nov 15, 2023
3 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/disk_path branch November 15, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants