Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add registry variable #243

Merged
merged 4 commits into from
Nov 17, 2023
Merged

add registry variable #243

merged 4 commits into from
Nov 17, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Nov 17, 2023

Background

Jira TF-10844

This branch updates the module to use the docker login changes introduced in hashicorp/terraform-random-tfe-utility#137.

All module tests are updated to accommodate this change.

(I also took the liberty to alphabetize and a couple of small clean up tasks while I was in there.)

TODO:

  • Change the module ref back to main

How Has This Been Tested

FDO tests have been run in comments below. (The one failed destroy was just an Azure bug.)

Also, I successfully ran this locally with the local.registry value being images.releases.hashicorp.com.

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/test standalone-mounted-disk

✅ Terraform Azure Standalone Mounted Disk (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/test public-active-active

✅ Terraform Azure Public Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/test private-tcp-active-active

✅ Terraform Azure Private TCP Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/test standalone-external

❌ Terraform Azure Standalone External (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ❌ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/destroy standalone-external

✅ Terraform Azure Standalone External (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/destroy private-active-active

✅ Terraform Azure Private Active/Active (FDO) - Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Nov 17, 2023

/test private-active-active

✅ Terraform Azure Private Active/Active (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth anniehedgpeth marked this pull request as ready for review November 17, 2023 21:08
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner November 17, 2023 21:08
@anniehedgpeth anniehedgpeth merged commit c2f8d87 into main Nov 17, 2023
3 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/TF-10844-registry branch November 17, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants