Support rolling_upgrade_policy for vm module #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate the PR @0x46616c6b, and apologize for only getting to the review so late. If I understand this correctly, then using the rolling upgrade policy directly conflicts with our upgrade guidance. If you have multiple TFE nodes up, they are coupled by the database. Having multiple nodes on different version will likely lead to conflicts, since database migrations might lead the schema changes. That is why currently upgrading TFE requires the user to stop TFE completely - which conflicts with a rolling upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I like to have the
rolling_upgrade_policyoptions for the VM module configurable. This helps to reduce downtimes or inaccessibilities for TFE.How Has This Been Tested
I forked the module and tested it in my production TFE environment. (I apply changes for TFE inside of TFE, so it is crucial not to have all VMs restarted at the same time.)