add disk_path to docker_compose #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
/test standalone-mounted-disk destroy=false ✅ Terraform Google Standalone Mounted Disk (FDO) - Test Report
|
|
/destroy standalone-mounted-disk ✅ Terraform Google Standalone Mounted Disk (FDO) - Destruction Report
|
p0pr0ck5
approved these changes
Nov 15, 2023
jkerry
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Relates: hashicorp/terraform-random-tfe-utility#135
While testing a backup, @miguelhrocha discovered that the disk_path was not set for FDO deployments. It had gone unnoticed since we had not done a backup test yet using these modules as it was using the default docker mount.
How Has This Been Tested
Passing test below. Also, here you can see that the postgres data is on the instance.