Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-11115, TF-11117, TF-11116] Adding object store details to output #296

Merged
merged 4 commits into from
Dec 10, 2024
Merged

TF-11115, TF-11117, TF-11116] Adding object store details to output #296

merged 4 commits into from
Dec 10, 2024

Conversation

kkavish
Copy link
Contributor

@kkavish kkavish commented Dec 10, 2024 •
edited
Loading

Adding object store details to output

Jira TF-11115
Jira TF-11116
Jira TF-11117

@kkavish kkavish requested a review from a team as a code owner December 10, 2024 12:51
@kkavish kkavish changed the title TF-11115, TF-11117, TF-11116] Adding object store connection string to output TF-11115, TF-11117, TF-11116] Adding object store details to output Dec 10, 2024
nikolasrieble
nikolasrieble previously approved these changes Dec 10, 2024
View reviewed changes
Copy link

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering: Would it make sense to keep the structure in the output? i.e. not add two outputs, but only one, which contains two fields?

That would communicate that the fields belong together.

@kkavish
Copy link
Contributor Author

kkavish commented Dec 10, 2024

Just wondering: Would it make sense to keep the structure in the output? i.e. not add two outputs, but only one, which contains two fields?

That would communicate that the fields belong together.

Makes sense.

nikolasrieble
nikolasrieble previously approved these changes Dec 10, 2024
View reviewed changes
@nikolasrieble nikolasrieble self-requested a review December 10, 2024 13:23
@nikolasrieble nikolasrieble merged commit c799c75 into hashicorp:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolasrieble nikolasrieble nikolasrieble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkavish @nikolasrieble