refactor(s3): bucket lifecycle configuration target state string

[tenstad]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

None

Description

Updates the desired target state for aws_s3_bucket_lifecycle_configuration to include both the value of transition_default_minimum_object_size and whether desired rules matches current rules, similarly to how it was before 5.95.

Instead of just showing if everything is up to date (with a boolean), one can now see if transition_default_minimum_object_size is correct separately from whether rules are correct.

Error pre 5.95

When applying changes to aws_s3_bucket_lifecycle_configuration.bucket-config, provider "provider["registry.terraform.io/hashicorp/aws"]" produced an unexpected new value: .transition_default_minimum_object_size: was cty.StringVal("all_storage_classes_128K"), but now cty.StringVal("").

Old state string

While waiting: timeout while waiting for state to become 'true' (last state: 'false', timeout: 1m0s)

New state string

While waiting: timeout while waiting for state to become 'transition_default_minimum_object_size=all_storage_classes_128K rules_equal=true' (last state: 'transition_default_minimum_object_size= rules_equal=true', timeout: 1m0s)

Relations

Relates #25939

References

Output from Acceptance Testing

Don't have an AWS account - unable to run acceptance test.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.