Skip to content

Conversation

@YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 28, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds logs to a progress message when log_type is Tail.

Currently, there is no way to validate this in tests. However, the machinery in #44864 and hashicorp/terraform-plugin-testing#570 validate that this works correctly.

Relations

Closes #0000

References

Output from Acceptance Testing

% make t T=TestAccLambdaInvokeAction_ K=lambda           
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-log-lambda-invoke-action 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvokeAction_'  -timeout 360m -vet=off
2025/10/29 14:00:56 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/29 14:00:56 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaInvokeAction_basic
=== PAUSE TestAccLambdaInvokeAction_basic
=== RUN   TestAccLambdaInvokeAction_withQualifier
=== PAUSE TestAccLambdaInvokeAction_withQualifier
=== RUN   TestAccLambdaInvokeAction_invocationTypes
=== PAUSE TestAccLambdaInvokeAction_invocationTypes
=== RUN   TestAccLambdaInvokeAction_logTypes
=== PAUSE TestAccLambdaInvokeAction_logTypes
=== RUN   TestAccLambdaInvokeAction_clientContext
=== PAUSE TestAccLambdaInvokeAction_clientContext
=== RUN   TestAccLambdaInvokeAction_complexPayload
=== PAUSE TestAccLambdaInvokeAction_complexPayload
=== CONT  TestAccLambdaInvokeAction_basic
=== CONT  TestAccLambdaInvokeAction_logTypes
=== CONT  TestAccLambdaInvokeAction_complexPayload
=== CONT  TestAccLambdaInvokeAction_clientContext
=== CONT  TestAccLambdaInvokeAction_invocationTypes
=== CONT  TestAccLambdaInvokeAction_withQualifier
--- PASS: TestAccLambdaInvokeAction_withQualifier (29.01s)
--- PASS: TestAccLambdaInvokeAction_clientContext (40.99s)
--- PASS: TestAccLambdaInvokeAction_logTypes (42.98s)
--- PASS: TestAccLambdaInvokeAction_complexPayload (47.55s)
--- PASS: TestAccLambdaInvokeAction_basic (54.21s)
--- PASS: TestAccLambdaInvokeAction_invocationTypes (76.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	82.167s

@YakDriver YakDriver requested a review from a team as a code owner October 28, 2025 19:11
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. labels Oct 28, 2025
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Oct 29, 2025
@YakDriver YakDriver changed the title aws_lambda_invoke_action: Output logs aws_lambda_invoke action: Output logs Oct 29, 2025
Copy link
Member

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit dcacb22 into main Oct 29, 2025
65 checks passed
@YakDriver YakDriver deleted the f-log-lambda-invoke-action branch October 29, 2025 21:18
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.19.0 milestone Oct 29, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 29, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants