Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically when detect tests add resources that should be bootstrapped instead #19813

Open
melinath opened this issue Oct 10, 2024 · 2 comments

Comments

@melinath
Copy link
Collaborator

What kind of contribution is this issue about?

Pull request UX

Details

Currently, we have to periodically go through and clean up resources clogging up quota because they were created instead of bootstrapped. This is a large manual effort (because it requires finding impacted tests and correcting them).

We should be able to automatically identify when specific types of resources (that should be bootstrapped) are instead being created in a test. We could then automatically alert the user to this fact. This would ideally be as an inline review comment based on the line where the resource shows up in the test file.

References

This may require also documenting how to use bootstrapped resources and cleaning up resources that should have been bootstrapped afterwards.

@melinath melinath changed the title Automatically detect tests that add resources that should be bootstrapped instead Automatically when detect tests add resources that should be bootstrapped instead Oct 10, 2024
@rileykarson
Copy link
Collaborator

Note that we may still want these resources to appear in examples some of the time. We may want some way to promote-to-bootstrapped within the test config, or omit resource blocks or something.

@rileykarson rileykarson added this to the Goals milestone Oct 14, 2024
@melinath
Copy link
Collaborator Author

melinath commented Nov 8, 2024

This would help prevent failures like #20252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants