Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Incorrect example attributes for google_access_context_manager_service_perimeter_dry_run_[in|e]gress_policy #20382

Closed
anilkumarmyla opened this issue Nov 19, 2024 · 5 comments

Comments

@anilkumarmyla
Copy link

anilkumarmyla commented Nov 19, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

Terraform v1.9.8
on

  • provider registry.terraform.io/hashicorp/google v6.12.0
  • provider registry.terraform.io/hashicorp/google-beta v6.12.0

Affected Resource(s)

google_access_context_manager_service_perimeter_dry_run_ingress_policy
google_access_context_manager_service_perimeter_dry_run_egress_policy
google_access_context_manager_service_perimeter_egress_policy
google_access_context_manager_service_perimeter_ingress_policy

Terraform Configuration

Debug Output

No response

Expected Behavior

The example usages of these resources are inaccurate and they should be as follows

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/access_context_manager_service_perimeter_dry_run_egress_policy
In google_access_context_manager_service_perimeter_dry_run_egress_policy, in perimeter definition

  • lifecycle -> ignore_changes should have [spec[0].egress_policies]

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/access_context_manager_service_perimeter_dry_run_ingress_policy
In google_access_context_manager_service_perimeter_dry_run_ingress_policy, in perimeter defition

  • status should be spec since we're dealing with a dry_run perimeter
  • lifecycle -> ignore_changes should have [spec[0].ingress_policies]

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/access_context_manager_service_perimeter_egress_policy
In google_access_context_manager_service_perimeter_egress_policy, in perimeter defition

  • lifecycle -> ignore_changes should have [status[0].egress_policies]

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/access_context_manager_service_perimeter_ingress_policy
In google_access_context_manager_service_perimeter_ingress_policy, in perimeter defition

  • lifecycle -> ignore_changes should have [status[0].ingress_policies]

Actual Behavior

No response

Steps to reproduce

  1. terraform apply

Important Factoids

No response

References

No response

b/380052088

@github-actions github-actions bot added forward/review In review; remove label to forward service/accesscontextmanager labels Nov 19, 2024
@ggtisc ggtisc assigned ggtisc and unassigned ggtisc Nov 20, 2024
@ggtisc ggtisc added documentation and removed bug forward/review In review; remove label to forward labels Nov 20, 2024
@melinath melinath added this to the Goals milestone Nov 25, 2024
@Charlesleonius
Copy link

I already fixed this the new version just hasn't been released to update the docs: #20439

@Charlesleonius
Copy link

@melinath Can we please close this

@melinath
Copy link
Collaborator

melinath commented Dec 3, 2024

resolved by GoogleCloudPlatform/magic-modules#12372

@melinath melinath closed this as completed Dec 3, 2024
@anilkumarmyla
Copy link
Author

status should be spec for google_access_context_manager_service_perimeter_dry_run_ingress_policy

This is missed in the PR

Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants