Allow stdin input for github auth token - feature request

[james-portman]

Feature Request:

Expected Behavior:
It would be nice for vault auth -method=github to take input/stdin from the user to provide their token, in the same way vault auth currently does.

Actual Behavior:

# vault auth -method github
GitHub token should be provided either as 'value' for 'token' key,
or via an env var VAULT_AUTH_GITHUB_TOKEN

# vault auth
Token (will be hidden): 

(waits for input)

[jefferai]

You can do this now by simply using a vault write command instead of vault auth. Simply use auth/<mount>/login and pass in token=-.

[james-portman]

Thanks for the alternate method.
It is still not very user friendly as they will need to type ctrl-D to end input rather than enter.
I was hoping that since the behaviour was already implemented in the default token auth that it would be possible to apply for Github auth too.

[boxrick]

This is something that I use myself but have had to write a small wrapper to make it work as expected.

Odd how there isn't consistent behaviour between the same command when simply specifying a different behaviour.

[jefferai]

It's possible, but if you're willing to give it a go a PR will make it happen much faster :-)

[jefferai]

@boxrick it's not actually the same command -- auth backends can define CLI helpers, and it's up to the CLI helper to decide how values should be passed in (if at all).

[jordansissel]

I found that can pass token=- to vault login similar to how token=- is suggested above for vault write

% echo "my github token" | vault login -method github token=-
Success! You are now authenticated. The token information displayed below
is already stored in the token helper. You do NOT need to run "vault login"
again. Future Vault requests will automatically use this token.
...