Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version constraints between Vault and its plugins #3710

Open
calvn opened this issue Dec 18, 2017 · 2 comments
Open

Version constraints between Vault and its plugins #3710

calvn opened this issue Dec 18, 2017 · 2 comments
Assignees
Labels
core Issues and Pull-Requests specific to Vault Core enhancement

Comments

@calvn
Copy link
Contributor

calvn commented Dec 18, 2017

Feature Request:

Implement a system to define plugin version constraints. This is useful on cases where plugin.HandshareConfig.ProtocolVersion has not changed, but a patch has been implemented in either Vault or a plugin.

Sample scenario: If a plugin (e.g. 0.1.0) has been updated to have a change in behavior (a change that applies to Vault 0.9.0+), but being ran under an older version of Vault (e.g. 0.8.3), core might not respect those changes. Both Vault versions are using ProtocolVersion: 3, and bumping this for a single plugin patch is non-ideal since it would force all other plugins to be rebuilt as well. In this scenario, Vault (0.8.3) would constraint the version of the plugin to be less than the version that implemented this change in behavior. On the other hand, if a newer version of Vault is being ran (0.9.0+), the constraint might be that the plugin needs to be 0.1.0 and above.

cc @briankassouf

@catsby catsby added enhancement core Issues and Pull-Requests specific to Vault Core labels Nov 7, 2019
@vishalnayak
Copy link
Contributor

Issues that are not reproducible and/or not had any interaction for a long time are stale issues. Sometimes even the valid issues remain stale lacking traction either by the maintainers or the community. In order to provide faster responses and better engagement with the community, we strive to keep the issue tracker clean and the issue count low. In this regard, our current policy is to close stale issues after 30 days. Closed issues will still be indexed and available for future viewers. If users feel that the issue is still relevant but is wrongly closed, we encourage reopening them.

Please refer to our contributing guidelines for details on issue lifecycle.

@kalafut kalafut added the tmp/rt label Jun 25, 2021
@kalafut kalafut reopened this Jun 25, 2021
@kalafut kalafut removed the tmp/rt label Jun 25, 2021
@heatherezell
Copy link
Contributor

@calvn is this issue still valid? Please let me know. :)

@heatherezell heatherezell self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues and Pull-Requests specific to Vault Core enhancement
Projects
None yet
Development

No branches or pull requests

5 participants