Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding generically as a base-compat-batteries dependency #87

Open
RyanGlScott opened this issue Jan 24, 2023 · 5 comments
Open

Comments

@RyanGlScott
Copy link
Member

No description provided.

@phadej
Copy link
Contributor

phadej commented Jan 24, 2023

You can add OneTuple as well to the list. Though it will have a major bump soon as constructor Solo is renamed to MkSolo

@RyanGlScott
Copy link
Member Author

OneTuple is already a dependency, if I'm not mistaken:

if !impl(ghc >= 9.0)
build-depends:
OneTuple >= 0.3 && < 0.4

@phadej
Copy link
Contributor

phadej commented Jan 24, 2023

Oh, nice! nevermind then. (But be prepared for a major bump).

@RyanGlScott
Copy link
Member Author

To make things a bit easier, I'll do this in separate PRs. I'll start out with OneTuple, which I've done in #88.

RyanGlScott added a commit that referenced this issue Mar 10, 2023
On the `base-compat-batteries` side, it depends on `foldable1-classes-compat`
to backport `Foldable1` and `Bifoldable1` to old versions of `base`.

Addresses one part of #87.
@RyanGlScott
Copy link
Member Author

I've opened #89 for foldable1-classes-compat.

Thinking about generically a bit more, adding support for it would imply that we would need to add GHC.Generics.Compat, as Generically(1) live in GHC.Generics. This would be new territory for base-compat-batteries, as it hasn't backported any modules in the GHC.* namespace yet. Perhaps it should, given how widely used GHC.Generics is, but I imagine that getting all of the CPP needed to support GHC.Generics.Compat across all supported GHC versions will be a fair bit of work.

For these reason, I'm considering holding off on adding generically to base-compat-batteries-0.13.0, as getting the details of GHC.Generics.Compat just right would be a long journey. Moreover, I don't want to let this hold up a release of base-compat-batteries that is compatible with GHC 9.6.

RyanGlScott added a commit that referenced this issue Mar 10, 2023
On the `base-compat-batteries` side, it depends on `foldable1-classes-compat`
to backport `Foldable1` and `Bifoldable1` to old versions of `base`.

Addresses one part of #87.
@RyanGlScott RyanGlScott changed the title Consider adding generically and foldable1 as base-compat-batteries dependencies Consider adding generically as a base-compat-batteries dependency Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants