Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.29 testsuite failure on 32-bit #512

Open
AdrianBunk opened this issue Oct 12, 2024 · 3 comments
Open

0.29 testsuite failure on 32-bit #512

AdrianBunk opened this issue Oct 12, 2024 · 3 comments

Comments

@AdrianBunk
Copy link

https://buildd.debian.org/status/logs.php?pkg=haskell-github&ver=0.29-1

spec/GitHub/Actions/CacheSpec.hs:27:86: warning: [GHC-97441] [-Woverflowed-literals]
    Literal 55000268087 is out of the Int range -2147483648..2147483647
   |
27 |             GH.repositoryCacheUsageActiveCachesSizeInBytes repoCacheUsage `shouldBe` 55000268087
   |                                                                                      ^^^^^^^^^^^
[ 3 of 21] Compiling GitHub.Actions.SecretsSpec ( spec/GitHub/Actions/SecretsSpec.hs, dist-ghc/build/github-test/github-test-tmp/GitHub/Actions/SecretsSpec.o, dist-ghc/build/github-test/github-test-tmp/GitHub/Actions/SecretsSpec.dyn_o )
[ 4 of 21] Compiling GitHub.Actions.WorkflowJobSpec ( spec/GitHub/Actions/WorkflowJobSpec.hs, dist-ghc/build/github-test/github-test-tmp/GitHub/Actions/WorkflowJobSpec.o, dist-ghc/build/github-test/github-test-tmp/GitHub/Actions/WorkflowJobSpec.dyn_o )

spec/GitHub/Actions/WorkflowJobSpec.hs:24:48: warning: [GHC-97441] [-Woverflowed-literals]
    Literal 9183275828 is out of the Int range -2147483648..2147483647
   |
24 |             GH.jobId workflowJob `shouldBe` Id 9183275828
   |                                                ^^^^^^^^^^

Running 1 test suites...
Test suite github-test: RUNNING...

GitHub.Actions.Artifacts
  artifactsForR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  decoding artifacts payloads
    decodes artifacts list payload [✘]
    decodes signle artifact payload [✘]
GitHub.Actions.Cache
  decoding cache payloads
    decodes cache list payload [✔]
    decodes cache usage for repo [✘]
    decodes cache usage for org [✔]
GitHub.Actions.Secrets
  decoding secrets payloads
    decodes selected repo list payload [✔]
    decodes secret list payload [✔]
    decodes public key payload [✔]
GitHub.Actions.Workflow
  decoding workflow payloads
    decodes workflow list [✔]
GitHub.Actions.WorkflowJob
  decoding workflow jobs payloads
    decodes workflow job [✘]
GitHub.Actions.WorkflowRuns
  decoding workflow runs payloads
    decodes workflow runs list [✘]
GitHub.Activity
  watchersForR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  myStarredR
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Commits
  commitsFor
    works [‐]
      # PENDING: no GITHUB_TOKEN
    limits the response [‐]
      # PENDING: no GITHUB_TOKEN
  diff
    works [‐]
      # PENDING: no GITHUB_TOKEN
    issue #155 [‐]
      # PENDING: no GITHUB_TOKEN
    issue #339 [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Events
  repositoryEventsR
    returns non empty list of events [‐]
      # PENDING: no GITHUB_TOKEN
  userEventsR
    returns non empty list of events [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Issues
  issuesForRepoR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  issueR
    fetches issue #428 [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Organizations
  publicOrganizationsFor'
    decodes simple organization json [✔]
    returns information about the user's organizations [‐]
      # PENDING: no GITHUB_TOKEN
  teamsOf
    parse [✔]
  membersOf
    parse [✔]
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.PublicSSHKeys
  publicSSHKeysFor'
    works [‐]
      # PENDING: no GITHUB_TOKEN
  publicSSHKeys' and publicSSHKey'
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.PullRequestReviews
  pullRequestReviewsR
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.PullRequests
  pullRequestsForR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  pullRequestPatchR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  decoding pull request payloads
    decodes a pull request 'opened' payload [✔]
    decodes a pull request 'review_requested' payload [✔]
    decodes a pull request 'team_requested' payload [✔]
  checking if a pull request is merged
    works [‐]
      # PENDING: no GITHUB_TOKEN
  Draft Pull Request
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.RateLimit
  rateLimitR
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Releases
  releasesR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  releaseR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  latestReleaseR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  releaseByTagNameR
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Repos
  repositoryR
    works [‐]
      # PENDING: no GITHUB_TOKEN
  currentUserRepos
    works [‐]
      # PENDING: no GITHUB_TOKEN
  userRepos
    works [‐]
      # PENDING: no GITHUB_TOKEN
  languagesFor'
    works [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.ReviewDecode
  PENDING state
    decodes review when submitted_at is missing [✔]
  Other states
    decodes review [✔]
GitHub.Search
  searchIssues
    decodes issue search response JSON [✔]
    performs an issue search via the API [‐]
      # PENDING: no GITHUB_TOKEN
  searchUsers
    performs a user search via the API [‐]
      # PENDING: no GITHUB_TOKEN
GitHub.Users
  userInfoFor
    decodes user json [✔]
    decodes user-bot json [✔]
    returns information about the user [‐]
      # PENDING: no GITHUB_TOKEN
    catches http exceptions [‐]
      # PENDING: no GITHUB_TOKEN
    should fail for organization [‐]
      # PENDING: no GITHUB_TOKEN
  ownerInfoFor
    works for users and organizations [‐]
      # PENDING: no GITHUB_TOKEN
  userInfoCurrentR
    returns information about the authenticated user [‐]
      # PENDING: no GITHUB_TOKEN
  usersFollowing
    works [‐]
      # PENDING: no GITHUB_TOKEN
  usersFollowedBy
    works [‐]
      # PENDING: no GITHUB_TOKEN

Failures:

  spec/GitHub/Actions/ArtifactsSpec.hs:23:23: 
  1) GitHub.Actions.Artifacts, decoding artifacts payloads, decodes artifacts list payload
       uncaught exception: ErrorCall
       Expected a Right and got a Left"Error in $.artifacts[0]['workflow_run'].id: parsing Int failed, value is either floating or will cause over or underflow 3.352897496e9"
       CallStack (from HasCallStack):
         error, called at spec/GitHub/Actions/ArtifactsSpec.hs:23:23 in main:GitHub.Actions.ArtifactsSpec

  To rerun use: --match "/GitHub.Actions.Artifacts/decoding artifacts payloads/decodes artifacts list payload/" --seed 2054602978

  spec/GitHub/Actions/ArtifactsSpec.hs:23:23: 
  2) GitHub.Actions.Artifacts, decoding artifacts payloads, decodes signle artifact payload
       uncaught exception: ErrorCall
       Expected a Right and got a Left"Error in $['workflow_run'].id: parsing Int failed, value is either floating or will cause over or underflow 3.353148947e9"
       CallStack (from HasCallStack):
         error, called at spec/GitHub/Actions/ArtifactsSpec.hs:23:23 in main:GitHub.Actions.ArtifactsSpec

  To rerun use: --match "/GitHub.Actions.Artifacts/decoding artifacts payloads/decodes signle artifact payload/" --seed 2054602978

  spec/GitHub/Actions/CacheSpec.hs:18:23: 
  3) GitHub.Actions.Cache, decoding cache payloads, decodes cache usage for repo
       uncaught exception: ErrorCall
       Expected a Right and got a Left"Error in $['active_caches_size_in_bytes']: parsing Int failed, value is either floating or will cause over or underflow 5.5000268087e10"
       CallStack (from HasCallStack):
         error, called at spec/GitHub/Actions/CacheSpec.hs:18:23 in main:GitHub.Actions.CacheSpec

  To rerun use: --match "/GitHub.Actions.Cache/decoding cache payloads/decodes cache usage for repo/" --seed 2054602978

  spec/GitHub/Actions/WorkflowJobSpec.hs:18:23: 
  4) GitHub.Actions.WorkflowJob, decoding workflow jobs payloads, decodes workflow job
       uncaught exception: ErrorCall
       Expected a Right and got a Left"Error in $.id: parsing Int failed, value is either floating or will cause over or underflow 9.183275828e9"
       CallStack (from HasCallStack):
         error, called at spec/GitHub/Actions/WorkflowJobSpec.hs:18:23 in main:GitHub.Actions.WorkflowJobSpec

  To rerun use: --match "/GitHub.Actions.WorkflowJob/decoding workflow jobs payloads/decodes workflow job/" --seed 2054602978

  spec/GitHub/Actions/WorkflowRunsSpec.hs:18:23: 
  5) GitHub.Actions.WorkflowRuns, decoding workflow runs payloads, decodes workflow runs list
       uncaught exception: ErrorCall
       Expected a Right and got a Left"Error in $['workflow_runs'][0].id: parsing Int failed, value is either floating or will cause over or underflow 3.353449941e9"
       CallStack (from HasCallStack):
         error, called at spec/GitHub/Actions/WorkflowRunsSpec.hs:18:23 in main:GitHub.Actions.WorkflowRunsSpec

  To rerun use: --match "/GitHub.Actions.WorkflowRuns/decoding workflow runs payloads/decodes workflow runs list/" --seed 2054602978

Randomized with seed 2054602978

Finished in 0.0930 seconds
61 examples, 5 failures, 39 pending
Test suite github-test: FAIL

@K0Te This seems to be due to #459

@iliastsi FYI
@andreasabel andreasabel changed the title 0.29 does not build on 32 bit Testsuite for 0.29 does not build on 32 bit Nov 11, 2024
@andreasabel
Copy link
Member

The testsuite does not build, but the library seems to build, does it?

@AdrianBunk AdrianBunk changed the title Testsuite for 0.29 does not build on 32 bit 0.29 testsuite failure on 32-bit Nov 11, 2024
@AdrianBunk
Copy link
Author

The testsuite does not build, but the library seems to build, does it?

You are right that the title was wrong, my mind was at "The Debian package build failed".

Even the testsuite does build, but there are test failures.

@andreasabel
Copy link
Member

From your report it seems that 2 golden values are wrong for a 32 bit system.
One could insert some #if conditionals so that if built on a 32 bit system, other golden values are used.
I do not have access to a 32 bit system, and GitHub actions also offers none, so this could not be tested in CI.
But if you want to fix this in a PR, I am happy to release such a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreasabel @AdrianBunk