Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upper bound on QuickCheck too low #140

Open
clinty opened this issue Apr 14, 2018 · 4 comments
Open

upper bound on QuickCheck too low #140

clinty opened this issue Apr 14, 2018 · 4 comments

Comments

@clinty
Copy link

clinty commented Apr 14, 2018

No description provided.

@hvr
Copy link
Member

hvr commented Apr 14, 2018 •
edited
Loading

test-suites don't participate in the install-plan solving when QuickCheck is used as a library dependency; hence we don't need to keep them working w/ the latest dependencies at all times.

@clinty
Copy link
Author

clinty commented Apr 14, 2018

Nevertheless this bound is needlessly restrictive and causes us additional work.

@bgamari
Copy link
Collaborator

bgamari commented Apr 24, 2018

@clinty, note that due to changes in semantics the testsuite currently doesn't pass with QuickCheck 2.11. I would be happy to accept a patch fixing this and bumping the bound.

@clinty
Copy link
Author

clinty commented Apr 24, 2018

Well, it works with

-    , testProperty "satisfyWith" satisfyWith
+    , testProperty "satisfyWith" (forAll arbitraryASCIIChar satisfyWith)

but I'm not sure that's the best fix.

@Lysxia Lysxia mentioned this issue Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make tests compatible with QuickCheck 2.10 Lysxia/attoparsec
3 participants
@clinty @hvr @bgamari