Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests compatible with QuickCheck 2.10 #148

Closed
wants to merge 1 commit into from
Closed

Make tests compatible with QuickCheck 2.10 #148

wants to merge 1 commit into from

Conversation

Lysxia
Copy link
Contributor

@Lysxia Lysxia commented Jan 10, 2019

The instance Arbitrary Char covers all unicode since QuickCheck 2.10. Here we really want bytes so use Word8 instead.

Fixes #140

@Lysxia
Make tests compatible with QuickCheck 2.10
7fb023a 
The instance `Arbitrary Char` covers all unicode since QuickCheck 2.10
@phadej
Copy link
Contributor

phadej commented Aug 27, 2019

Crap, I didn't notice this when making #162... Thanks @Lysxia for writing this.

@Lysxia
Copy link
Contributor Author

Lysxia commented Aug 27, 2019

No problem! So it's solved?

@Lysxia Lysxia closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upper bound on QuickCheck too low
2 participants
@Lysxia @phadej