Skip to content

Commit d86abd8

Browse files
committed
Drop support of GHC 8.4
1 parent 578e2a2 commit d86abd8

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
fail-fast: true
1919
matrix:
2020
os: [ubuntu-latest]
21-
ghc: ['8.4', '8.6', '8.8', '8.10', '9.0', '9.2', '9.4', '9.6', '9.8', '9.10', '9.12']
21+
ghc: ['8.6', '8.8', '8.10', '9.0', '9.2', '9.4', '9.6', '9.8', '9.10', '9.12']
2222
include:
2323
- os: macOS-latest
2424
ghc: 'latest'
@@ -49,7 +49,6 @@ jobs:
4949
cd bytestring-*/
5050
cabal bench --enable-tests --enable-benchmarks --benchmark-option=-l all
5151
- name: Haddock
52-
if: matrix.ghc != '8.4'
5352
run: |
5453
cd bytestring-*/
5554
cabal haddock all

bench/BenchReadInt.hs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ import Test.Tasty.Bench
1818
import Data.Int
1919
import Data.Word
2020
import Numeric.Natural
21-
#if !(MIN_VERSION_base(4,11,0))
22-
import Data.Semigroup (Semigroup((<>)))
23-
#endif
2421
import Data.Monoid (mconcat)
2522

2623
------------------------------------------------------------------------------

bytestring.cabal

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,16 @@ Author: Don Stewart,
5757
Maintainer: Haskell Bytestring Team <[email protected]>, Core Libraries Committee
5858
Homepage: https://github.com/haskell/bytestring
5959
Bug-reports: https://github.com/haskell/bytestring/issues
60-
Tested-With: GHC==9.12.1,
61-
GHC==9.10.1,
60+
Tested-With: GHC==9.12.2,
61+
GHC==9.10.2,
6262
GHC==9.8.4,
63-
GHC==9.6.6,
63+
GHC==9.6.7,
6464
GHC==9.4.8,
6565
GHC==9.2.8,
6666
GHC==9.0.2,
6767
GHC==8.10.7,
6868
GHC==8.8.4,
69-
GHC==8.6.5,
70-
GHC==8.4.4
69+
GHC==8.6.5
7170
Build-Type: Simple
7271
extra-source-files: README.md Changelog.md include/bytestring-cpp-macros.h
7372

@@ -110,7 +109,7 @@ common language
110109

111110
library
112111
import: language
113-
build-depends: base >= 4.11 && < 5, ghc-prim, deepseq, template-haskell
112+
build-depends: base >= 4.12 && < 5, ghc-prim, deepseq, template-haskell
114113

115114
if impl(ghc < 9.4)
116115
build-depends: data-array-byte >= 0.1 && < 0.2
@@ -249,8 +248,7 @@ benchmark bytestring-bench
249248
hs-source-dirs: bench
250249

251250
ghc-options: -O2 "-with-rtsopts=-A32m"
252-
if impl(ghc >= 8.6)
253-
ghc-options: -fproc-alignment=64
251+
-fproc-alignment=64
254252
build-depends: base,
255253
bytestring,
256254
deepseq,

include/bytestring-cpp-macros.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ which are known not to trap (either to the kernel for emulation, or crash).
2323

2424

2525
#define HS_UNALIGNED_ByteArray_OPS_OK \
26-
MIN_VERSION_base(4,12,0) \
27-
&& (MIN_VERSION_base(4,16,1) || HS_UNALIGNED_POKES_OK)
26+
MIN_VERSION_base(4,16,1) || HS_UNALIGNED_POKES_OK
2827
/*
2928
The unaligned ByteArray# primops became available with base-4.12.0/ghc-8.6,
3029
but require an unaligned-friendly host architecture to be safe to use

0 commit comments

Comments
 (0)