Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict aliasing violations from our C code #594

Open
clyring opened this issue Jun 13, 2023 · 0 comments
Open

Remove strict aliasing violations from our C code #594

clyring opened this issue Jun 13, 2023 · 0 comments

Comments

@clyring
Copy link
Member

clyring commented Jun 13, 2023

Although we've enabled -fno-strict-aliasing in #582, I would on principle rather we just didn't have any strict-aliasing violations in our code. But:

  • I expect the bytestring C code contains little (if any) of the sort of code that actually gets performance wins from -fstrict-aliasing
  • Although the strict-aliasing-compliant idioms are not uglier than what we are currently doing instead, they are not prettier in any way except that they remove the need to remember that -fno-strict-aliasing has been set.

So this is an extremely-low-priority task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant