Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose functions from string→double? #35

Open
unhammer opened this issue Nov 7, 2022 · 1 comment
Open

expose functions from string→double? #35

unhammer opened this issue Nov 7, 2022 · 1 comment

Comments

@unhammer
Copy link

unhammer commented Nov 7, 2022

IIUC, this only exposes functions from doubles to strings, not the other way around, but https://github.com/google/double-conversion/blob/master/double-conversion/string-to-double.h has functions from string-to-double – would it make sense to include both directions?

The default read is pretty slow on doubles; there is bytestring-lexing which is faster than default, but I'm guessing double-conversion could be even faster – or perhaps fast_float would be a better option?

@Haskell-mouse
Copy link
Collaborator

Thanks, @unhammer for pointing this out. I will think about it and maybe try to make performance tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants