_avatarV1CirclesStatus do return lastTouched time even if Circles contract get stopped

[hats-bug-reporter]

Github username: --
Twitter username: --
Submission hash (on-chain): 0xd804576013ecdf0aec67ad9966aef4660d7808b4795dab9cdb1ddf1eab64edb7
Severity: high

Description:
Description
_avatarV1CirclesStatus is responsible for checking the status of circle contract in case if circle contract do not stop it return the circlev1 contract if it exist and the last update time, but when circle contract egt stopped and not exist even in that case the function return last update time with CIRCLES_STOPPED_V1 as address parameter.

 // return the stopped status of the Circles contract, and the last touched time
            return (CIRCLES_STOPPED_V1, lastTouched);

which shouldn't be the case, at this point it should zero as lastTouched as the comment also mention this,

Additionally, return the last touched time of the Circles v1 token (ie. the last time it minted CRC),
     * if the token exists, or zero if it does not.

Their in case of CIRCLES_STOPPED_V1 it returns lastUpdated time, which could result in wrong checked passed under registerhuman function.

This should return 0 instead of lastTouched.

 return (CIRCLES_STOPPED_V1, 0);

[satyam455]

@benjaminbollen can you leave a comment, why it is invalid?

[satyam455]

Hey @benjaminbollen since according to comment it mentioned in case token not exist it should return 0 but it do not,
where as it return lastTouched timestamp for both exist token and the token which do not exist.

 * @return address of the Circles contract if it exists and is not stopped, or zero address if no Circles exist
     * or CIRCLES_STOPPED_V1 if the Circles contract is stopped.
     * Additionally, return the last touched time of the Circles v1 token (ie. the last time it minted CRC),
     * if the token exists, or zero if it does not.

[satyam455]

@benjaminbollen can you reply please?? and check again!

[benjaminbollen]

the comment explicitly says "returns zero for lastTouched if the v1 token DOES NOT EXIST, but return lastTouch in all other cases", which is what it does.

I do not know what to comment on your issue. Maybe re-read the comment yourself?

[benjaminbollen]

for clarity, your issue itself does not compute to something sensible. So yes, it is invalid

[benjaminbollen]

maybe it helps for you to clarify that a "stopped token" does not remove the v1 token. It keeps existing, and the lastTouched time is still valuable information