You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: Description
The contract wrapper1155 return bool on transferFrom() call. Which is not checked. It is assumed to be true.
Attack Scenario
There can be a scenario if the transferFrom() fails, it returns the bool false instead of reverting. Which will lead to 2 exploits.
In _mergePositions() users will be able to get CollateralTokens without providing any WrappedERC1155 tokens. https://github.com/hats-finance/SeeR-PM-0x899bc13919880db76edf4ccd72bdfa5dfa666fb7/blob/6e5db716e44e251fcee6abd7c1f6a8d6e36db910/contracts/src/Router.sol#L117
In redeemPositions any user will be able to claim winning amount. https://github.com/hats-finance/SeeR-PM-0x899bc13919880db76edf4ccd72bdfa5dfa666fb7/blob/6e5db716e44e251fcee6abd7c1f6a8d6e36db910/contracts/src/Router.sol#L182
The text was updated successfully, but these errors were encountered:
Github username: @cpp-phoenix
Twitter username: 0xrochimaru
Submission hash (on-chain): 0xf427b6386fa33a850e1cb250bca81406c37895c18fecc0689002f451b980e5b8
Severity: high
Description:
Description
The contract
wrapper1155
return bool ontransferFrom()
call. Which is not checked. It is assumed to be true.Attack Scenario
There can be a scenario if the
transferFrom()
fails, it returns the bool false instead of reverting. Which will lead to 2 exploits._mergePositions()
users will be able to get CollateralTokens without providing any WrappedERC1155 tokens.https://github.com/hats-finance/SeeR-PM-0x899bc13919880db76edf4ccd72bdfa5dfa666fb7/blob/6e5db716e44e251fcee6abd7c1f6a8d6e36db910/contracts/src/Router.sol#L117
redeemPositions
any user will be able to claim winning amount.https://github.com/hats-finance/SeeR-PM-0x899bc13919880db76edf4ccd72bdfa5dfa666fb7/blob/6e5db716e44e251fcee6abd7c1f6a8d6e36db910/contracts/src/Router.sol#L182
The text was updated successfully, but these errors were encountered: