Skip to content

Incorrect order of properties when creating a new Mon #5

@StErMi

Description

@StErMi

Code: https://github.com/hats-finance/games/blob/main/contracts/Game.sol#L190-L194

The struct of the Mon is

  struct Mon {
    uint8 water;
    uint8 air;
    uint8 fire;
    uint8 speed;
  }

so the correct order when creating a new Mon should be

-newMon = Mon(fire, water, air, speed);
+newMon = Mon(water, air, fire, speed);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions