Feat/update design #11
Conversation
| .contactus-form { | ||
| width: 100%; | ||
| max-width: 386px; | ||
| &__title { |
There was a problem hiding this comment.
I would strongly recommend to use full snake case for example instead of &__title so contactus-form__title. This way it's super easy to find the right class in case of debugging/making changes. Besides I think it's very confusing that half of the project is written in certain way and the other in different way - so in my opinion we have to go with one way.
| export default function ContactUs() { | ||
| const { t } = useTranslation(); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
No send button to this form?
Deploying with
|
| Latest commit: |
6c361f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0dc314c.web-2l1.pages.dev |
| <label>{t("Landing.ContactUs.position")}</label> | ||
| <input type="text" /> | ||
| </div> | ||
| <button className="button contactus-form__button"> |
There was a problem hiding this comment.
@mwogates Let's just make the button disabled when at least one of the fields is empty.
I would also add validation for the email address with a red error in case it's invalid email. The send button should be disabled in that case too.
|
@mwogates I've pushed some small updates. Anyhow as we still discuss about the way the newsletter will work so this PR will be on hold. |
No description provided.