fix: Adds better error handling of workspace loading errors#1169
Merged
Conversation
phantomjinx
force-pushed
the
app-status
branch
from
3a6c749 to
e5474fb
Compare
Member
Author
|
So I found I was having issues with the workspace being empty (due to an unrelated error) and the console message that the workspace was empty was buried in the console. What was more obvious was the blank page when a connection was attempted. Therefore, the idea is to have a status plugin pop up that checks on the workspace. If it succeeds then the plugin never appears. However, if there is a failure then at least a single plugin is loaded and displayed giving the user some indication of the issue.
|
tadayosi
requested changes
Oct 17, 2024
Member
tadayosi
left a comment
tadayosi
left a comment
There was a problem hiding this comment.
Overall the enhancement looks great, but there are a few considerations we'd like to take care of a bit.
* Adds a status plugin for displaying errors messages if the workspace
failed to load. Such errors can get lost in the console log and a blank
page is the result in the client.
* workspace.ts
* If an error occurs then add them to a collection in the workspace
* Provides an api for quizzing the workspace on whether it has errored
* console-status
* Plugin that is only active if
* there is a current connection (no point in displaying if nothing
has been connected to yet)
* there are no mbeans collected from the jolokia connection
* Errors were flagged from the workspace
* Assuming the plugin is active, offer a component that provides
notification of the workspace
*
phantomjinx
force-pushed
the
app-status
branch
from
e5474fb to
f0a8cd6
Compare
tadayosi
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a status plugin for displaying errors messages if the workspace failed to load. Such errors can get lost in the console log and a blank page is the result in the client.
workspace.ts
app-status