Update HawtioConfig type to match @hawtio/react hawtconfig.json model

[tadayosi]

hawtio-operator/pkg/apis/hawtio/v1alpha1/hawtio_types.go

Lines 173 to 182 in 92a486d

	type HawtioConfig struct {
	// The information to be displayed in the About page
	About HawtioAbout `json:"about,omitempty"`
	// The UI branding
	Branding HawtioBranding `json:"branding,omitempty"`
	// The OpenShift related configuration
	Online HawtioOnline `json:"online,omitempty"`
	// Disables UI components with matching routes
	DisabledRoutes []string `json:"disabledRoutes,omitempty"`
	}

[tadayosi]

@phantomjinx I found that there is online.consoleLink option in hawtconfig.json for hawtio-operator, which is not present in hawtio/react. Do you know if it's used in hawtio-online? If it's not dead code but isn't utilised in hawtio-online, it might be something we miss.

hawtio-operator/pkg/apis/hawtio/v1alpha1/hawtio_types.go

Lines 230 to 249 in e654859

	// The configuration for the OpenShift Web console link.
	// A link is added to the application menu when the Hawtio deployment is equal to 'cluster'.
	// Otherwise, a link is added to the Hawtio project dashboard.
	ConsoleLink HawtioConsoleLink `json:"consoleLink,omitempty"`
	}
	// The configuration for the OpenShift Web console link
	type HawtioConsoleLink struct {
	// The text display for the link
	Text string `json:"text,omitempty"`
	// The section of the application menu in which the link should appear.
	//It is only applicable when the Hawtio deployment type is equal to 'cluster'.
	// +optional
	Section string `json:"section,omitempty"`
	// The path, relative to the Hawtio status URL, for the icon used in front of the link in the application menu.
	// It is only applicable when the Hawtio deployment type is equal to 'cluster'.
	// The image should be square and will be shown at 24x24 pixels.
	// +optional
	ImageRelativePath string `json:"imageRelativePath,omitempty"`
	}

[tadayosi]

OK, I learned hard that the HawtioConfig type here doesn't necessarily reflect the type definition provided by @hawtio/react. HawtioConfig generally only needs type definitions for what the operater uses. Ultimately, what is really needed is the online.consoleLink for the operator, and the rest (even About and Branding) are not really needed here.
(@phantomjinx That answers my own question above. It's ok that we don't observe the usages of online.consoleLink anywhere else, since hawtio-operator is where the option is consumed.)

That concludes this task of syncing the definitions between @hawtio/react and hawtio-operator is not needed.

[tadayosi]

In addition, the recent changes I added to hawtconfig.json at @hawtio/react hawtio/hawtio-next#646 uses union type boolean | string[]. JS/TS is fine to handle union types but Go isn't. That makes it really hard to encode the type definitions in the operator, so ultimately we should avoid using union types.

But for now, I don't think the operator will use the newly added option jmx.workspace, and it really shouldn't as the operator should be agnostic to the configurations of specific Hawtio plugins, even if it's as basic as JMX.

[tadayosi]

I'm closing it as 'Wont Do'.