Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry types broken (becomes a Bytes instance) in CallProcedure #107

Open
kevinresol opened this issue May 12, 2020 · 2 comments
Open

Geometry types broken (becomes a Bytes instance) in CallProcedure #107

kevinresol opened this issue May 12, 2020 · 2 comments

Comments

@kevinresol
Copy link
Member

Basically because typeCast now passes GEOMETRY as raw bytes,

tink_sql/src/tink/sql/drivers/node/MySql.hx

Line 138 in f1434ff

case v: v.hxToBytes();

and CallProcedure carries no runtime type info. So when it arrives ResultParser, the Bytes will be passed through as is:

tink_sql/src/tink/sql/parse/ResultParser.hx

Line 55 in f1434ff

case null: value;

kevinresol added a commit that referenced this issue May 12, 2020
@kevinresol
Bandaid #107
0266bdc
@kevinresol
Copy link
Member Author

Pushed a bandaid fix. It sucks. But I need it quick for now. Sorry about that.

@kevinresol
Copy link
Member Author

Btw I guess we can move parseGeometryValue into the geojson library

@kevinresol kevinresol mentioned this issue May 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinresol