Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually you can't set the dataSource to null. #99

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aW4KeNiNG
Copy link
Member

@aW4KeNiNG aW4KeNiNG commented Feb 1, 2017

I don't know exactly why the get_dataSource method requires to create the dataSource. It could be useful to check from outside if the dataSource is null (in a point of view of list management in a dynamic way).

If you see that it is necessary, feel free to close the PR.

@ianharrigan
Copy link
Member

Could be an over sight on my part, will need to think about if there was a reason to create if not null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants