GH-39: Introduce factory_bot_rails gem instead of factory_girl_rails gem

Author: mrk21

Gemfile

@@ -42,7 +42,7 @@ gem "exception_notification"
 gem "haml-rails"
 gem "simple_form", '~> 3.5.0'
 gem "kaminari"
-gem "factory_girl_rails"
+gem "factory_bot_rails"
 gem 'faker'
 gem "cancan", github: "ryanb/cancan", branch: "2.0"
 gem 'therubyracer'

Gemfile.lock

@@ -113,10 +113,10 @@ GEM
       actionmailer (>= 4.0, < 6)
       activesupport (>= 4.0, < 6)
     execjs (2.7.0)
-    factory_girl (4.9.0)
+    factory_bot (4.8.2)
       activesupport (>= 3.0.0)
-    factory_girl_rails (4.9.0)
-      factory_girl (~> 4.9.0)
+    factory_bot_rails (4.8.2)
+      factory_bot (~> 4.8.2)
       railties (>= 3.0.0)
     faker (1.8.7)
       i18n (>= 0.7)
@@ -311,7 +311,7 @@ DEPENDENCIES
   ci_reporter
   dalli
   exception_notification
-  factory_girl_rails
+  factory_bot_rails
   faker
   font-awesome-less (~> 4.5.0)
   haml-rails

spec/controllers/comments_controller_spec.rb

@@ -23,15 +23,15 @@
   # This should return the minimal set of attributes required to create a valid
   # Comment. As you add validations to Comment, be sure to
   # adjust the attributes here as well.
-  let(:valid_attributes) { FactoryGirl.attributes_for(:comment).slice(:body) }
+  let(:valid_attributes) { FactoryBot.attributes_for(:comment).slice(:body) }
 
   # This should return the minimal set of values that should be in the session
   # in order to pass any filters (e.g. authentication) defined in
   # CommentsController. Be sure to keep this updated too.
   let(:valid_session) { { user_id: @comment.user_id } }
 
   before do
-    @comment = FactoryGirl.create(:comment)
+    @comment = FactoryBot.create(:comment)
     @post = @comment.post
   end
 
@@ -135,7 +135,7 @@
       end
     end
     context "another's comment on another's post" do
-      let(:session){ {user_id: FactoryGirl.create(:user).id} }
+      let(:session){ {user_id: FactoryBot.create(:user).id} }
       it "fail to destroy the requested comment" do
         expect{subject}.to raise_error CanCan::Unauthorized
       end

spec/controllers/posts_controller_spec.rb

@@ -23,15 +23,15 @@
   # This should return the minimal set of attributes required to create a valid
   # Post. As you add validations to Post, be sure to
   # adjust the attributes here as well.
-  let(:valid_attributes) { FactoryGirl.attributes_for(:post) }
+  let(:valid_attributes) { FactoryBot.attributes_for(:post) }
 
   # This should return the minimal set of values that should be in the session
   # in order to pass any filters (e.g. authentication) defined in
   # PostsController. Be sure to keep this updated too.
   let(:valid_session) { { user_id: @post.user_id } }
 
   before do
-    @post = FactoryGirl.create(:post)
+    @post = FactoryBot.create(:post)
   end
 
   describe "GET index" do

spec/controllers/sessions_controller_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe SessionsController do
-  let(:valid_attributes){ FactoryGirl.attributes_for(:user) }
+  let(:valid_attributes){ FactoryBot.attributes_for(:user) }
   before do
     @user = User.create!(valid_attributes)
   end

spec/controllers/users_controller_spec.rb

@@ -23,15 +23,15 @@
   # This should return the minimal set of attributes required to create a valid
   # User. As you add validations to User, be sure to
   # adjust the attributes here as well.
-  let(:valid_attributes) { FactoryGirl.attributes_for(:user) }
+  let(:valid_attributes) { FactoryBot.attributes_for(:user) }
 
   # This should return the minimal set of values that should be in the session
   # in order to pass any filters (e.g. authentication) defined in
   # UsersController. Be sure to keep this updated too.
   let(:valid_session) { { user_id: @user.id } }
 
   before do
-    @user = FactoryGirl.create(:user)
+    @user = FactoryBot.create(:user)
   end
 
   describe "GET show" do

spec/factories/comments.rb

@@ -1,6 +1,6 @@
 # Read about factories at https://github.com/thoughtbot/factory_girl
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :comment do
     user
     post

spec/factories/posts.rb

@@ -1,6 +1,6 @@
 # Read about factories at https://github.com/thoughtbot/factory_girl
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :post do
     user
     text { Faker::Lorem.sentence(10) }

spec/factories/users.rb

@@ -1,6 +1,6 @@
 # Read about factories at https://github.com/thoughtbot/factory_girl
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :user do
     sequence(:username) {|n| Faker::Internet.user_name[0..8] + n.to_s }
     password { 'abcdefghjkmnpqrtuvwxyzABCDEFGHJKLMNPQRTUVWXY346789+-*#$_'.chars.sample(8).join }

spec/models/post_spec.rb

@@ -1,10 +1,10 @@
 require 'rails_helper'
 
 describe Post do
-  subject(:post){ FactoryGirl.create(:post) }
+  subject(:post){ FactoryBot.create(:post) }
   describe "destroy" do
     it "also destroys comments" do
-      comments = FactoryGirl.create_list(:comment, 2, post: post)
+      comments = FactoryBot.create_list(:comment, 2, post: post)
       post.destroy
       expect{comments[0].reload}.to raise_error ActiveRecord::RecordNotFound
       expect{comments[1].reload}.to raise_error ActiveRecord::RecordNotFound
@@ -13,9 +13,9 @@
 
   describe '#cached_comments' do
     before do
-      @post = FactoryGirl.create(:post)
+      @post = FactoryBot.create(:post)
       @post.flush_cache
-      @comments = FactoryGirl.create_list(:comment, 2, post: @post).sort_by(&:id)
+      @comments = FactoryBot.create_list(:comment, 2, post: @post).sort_by(&:id)
     end
     context 'before caching' do
       it 'gets comments from DB' do
@@ -47,7 +47,7 @@
         expect(Rails.cache.read([@post, 'comments'])).to be_present
       end
       it 'clears cache when another comment are added' do
-        FactoryGirl.create(:comment, post: @post)
+        FactoryBot.create(:comment, post: @post)
         expect(Rails.cache.read([@post, 'comments'])).to be_blank
       end
       it 'clears cache when one of the comments is destoryed' do

spec/models/user_spec.rb

@@ -1,11 +1,11 @@
 require 'rails_helper'
 
 describe User do
-  subject(:user){ FactoryGirl.create(:user) }
+  subject(:user){ FactoryBot.create(:user) }
   describe "password validation" do
     context "on create" do
       it "fail if length is 5" do
-        user = FactoryGirl.build(:user, password: "hogeh")
+        user = FactoryBot.build(:user, password: "hogeh")
         expect(user.save).to eq false
         expect(user.errors[:password]).not_to be_nil
       end
@@ -37,23 +37,23 @@
   end
   describe "destroy" do
     it "also destroys my posts" do
-      posts = FactoryGirl.create_list(:post, 2, user: user)
+      posts = FactoryBot.create_list(:post, 2, user: user)
       user.destroy
       expect{posts[0].reload}.to raise_error ActiveRecord::RecordNotFound
       expect{posts[1].reload}.to raise_error ActiveRecord::RecordNotFound
     end
     it "also destroys comments on destroyed posts" do
-      post = FactoryGirl.create(:post, user: user)
-      comments = FactoryGirl.create_list(:comment, 2, post: post)
+      post = FactoryBot.create(:post, user: user)
+      comments = FactoryBot.create_list(:comment, 2, post: post)
       user.destroy
       expect{comments[0].reload}.to raise_error ActiveRecord::RecordNotFound
       expect{comments[1].reload}.to raise_error ActiveRecord::RecordNotFound
     end
     it "also destroys my comments on other's posts" do
-      comments = FactoryGirl.create_list(:comment, 2, user: user)
+      comments = FactoryBot.create_list(:comment, 2, user: user)
       user.destroy
       expect{comments[0].reload}.to raise_error ActiveRecord::RecordNotFound
       expect{comments[1].reload}.to raise_error ActiveRecord::RecordNotFound
     end
   end
-end
+end

spec/requests/comments_spec.rb

@@ -2,7 +2,7 @@
 
 describe "Comments" do
   before do
-    @post = FactoryGirl.create(:post)
+    @post = FactoryBot.create(:post)
   end
   describe "GET /posts/:post_id/comments/new" do
     it "works! (now write some real specs)" do

spec/requests/posts_spec.rb

@@ -2,7 +2,7 @@
 
 describe "Posts" do
   before do
-    @post = FactoryGirl.create(:post)
+    @post = FactoryBot.create(:post)
   end
   describe "GET /posts" do
     it "works! (now write some real specs)" do

spec/requests/users_spec.rb

@@ -2,7 +2,7 @@
 
 describe "Users" do
   before do
-    @user = FactoryGirl.create(:user)
+    @user = FactoryBot.create(:user)
   end
   describe "GET /users" do
     it "works! (now write some real specs)" do

spec/views/comments/edit.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "comments/edit" do
   before(:each) do
-    @comment = assign(:comment, FactoryGirl.create(:comment))
+    @comment = assign(:comment, FactoryBot.create(:comment))
   end
 
   it "renders the edit comment form" do

spec/views/comments/new.html.haml_spec.rb

@@ -2,8 +2,8 @@
 
 describe "comments/new" do
   before(:each) do
-    @post = assign(:post,    FactoryGirl.create(:post))
-    assign(:comment, FactoryGirl.build(:comment))
+    @post = assign(:post,    FactoryBot.create(:post))
+    assign(:comment, FactoryBot.build(:comment))
   end
 
   it "renders new comment form" do

spec/views/layouts/application.html.haml_spec.rb

@@ -15,7 +15,7 @@
   end
 
   context "with login" do
-    let(:user){ FactoryGirl.create(:user) }
+    let(:user){ FactoryBot.create(:user) }
     it { should_not have_xpath "//a[@href='#{new_sessions_path}']" }
     it { should have_xpath "//a[@href='#{sessions_path}']" }
     it { should have_xpath "//a[@href='#{new_post_path}']" }

spec/views/posts/edit.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "posts/edit" do
   before(:each) do
-    @post = assign(:post, FactoryGirl.create(:post))
+    @post = assign(:post, FactoryBot.create(:post))
   end
 
   it "renders the edit post form" do

spec/views/posts/index.html.haml_spec.rb

@@ -3,7 +3,7 @@
 describe "posts/index" do
   before(:each) do
     @q = Post.search
-    @posts = assign(:posts, Kaminari.paginate_array(FactoryGirl.create_list(:post, 2)))
+    @posts = assign(:posts, Kaminari.paginate_array(FactoryBot.create_list(:post, 2)))
   end
 
   context "without login" do

spec/views/posts/new.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "posts/new" do
   before(:each) do
-    assign(:post, FactoryGirl.build(:post))
+    assign(:post, FactoryBot.build(:post))
   end
 
   it "renders new post form" do

spec/views/posts/show.html.haml_spec.rb

@@ -2,8 +2,8 @@
 
 describe "posts/show" do
   subject { render; response.body }
-  let(:current_user){ FactoryGirl.create(:user) }
-  let(:post){ FactoryGirl.create(:post) }
+  let(:current_user){ FactoryBot.create(:user) }
+  let(:post){ FactoryBot.create(:post) }
   before do
     Rails.cache.clear
     allow(controller).to receive(:current_user).and_return(current_user)
@@ -16,7 +16,7 @@
   it { should match(post.user.username) }
 
   context "owned by login user" do
-    let(:post){ FactoryGirl.create(:post, user: current_user) }
+    let(:post){ FactoryBot.create(:post, user: current_user) }
     it { should have_xpath "//a[@href='#{edit_post_path(post)}']" }
   end
 
@@ -26,8 +26,8 @@
 
   describe "comments" do
     before do
-      FactoryGirl.create_list(:comment, 3, post: post)
-      FactoryGirl.create_list(:comment, 2, post: post, user: current_user)
+      FactoryBot.create_list(:comment, 3, post: post)
+      FactoryBot.create_list(:comment, 2, post: post, user: current_user)
     end
     it { should have_xpath "//a[contains(@href,'/comments/')][contains(@href,'/edit')]", count: 2 }
   end

spec/views/sessions/new.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "sessions/new.html.haml" do
   before do
-    assign(:user, FactoryGirl.build(:user))
+    assign(:user, FactoryBot.build(:user))
   end
   it do
     render

spec/views/users/edit.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "users/edit" do
   before(:each) do
-    @user = assign(:user, FactoryGirl.create(:user))
+    @user = assign(:user, FactoryBot.create(:user))
   end
 
   it "renders the edit user form" do

spec/views/users/new.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "users/new" do
   before(:each) do
-    assign(:user, FactoryGirl.build(:user))
+    assign(:user, FactoryBot.build(:user))
   end
 
   it "renders new user form" do

spec/views/users/show.html.haml_spec.rb

@@ -2,7 +2,7 @@
 
 describe "users/show" do
   subject { render; response.body }
-  let(:current_user){ FactoryGirl.create(:user) }
+  let(:current_user){ FactoryBot.create(:user) }
   before do
     allow(controller).to receive(:current_user).and_return(current_user)
     allow(view).to receive(:current_user).and_return(current_user)
@@ -18,7 +18,7 @@
   end
 
   context "another user" do
-    let(:user){ FactoryGirl.create(:user) }
+    let(:user){ FactoryBot.create(:user) }
     it { should_not have_xpath "//a[contains(@href,'/edit')]" }
   end
 end