fixed logger not working when there is no stdout attached for redirecting output

hectorgimenez · hectorgimenez · commit 898172764076 · 2024-03-24T22:14:37.000+09:00
diff --git a/cmd/koolo/log/logger.go b/cmd/koolo/log/logger.go
@@ -24,10 +24,11 @@ func NewLogger(debug bool, logDir string) (*slog.Logger, error) {
 	}
 
 	fileName := "koolo-log-" + time.Now().Format("2006-01-02-15-04-05") + ".txt"
-	logFileHandler, err := os.Create(logDir + "/" + fileName)
+	lfh, err := os.Create(logDir + "/" + fileName)
 	if err != nil {
 		return nil, err
 	}
+	logFileHandler = lfh
 
 	level := slog.LevelDebug
 	if !debug {
@@ -38,7 +39,7 @@ func NewLogger(debug bool, logDir string) (*slog.Logger, error) {
 		Level: level,
 	}
 
-	handler := slog.NewTextHandler(io.MultiWriter(os.Stdout, logFileHandler), opts)
+	handler := slog.NewTextHandler(io.MultiWriter(logFileHandler, os.Stdout), opts)
 
 	return slog.New(handler), nil
 }

Original file line number	Diff line number	Diff line change
`@@ -24,10 +24,11 @@ func NewLogger(debug bool, logDir string) (*slog.Logger, error) {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`fileName := "koolo-log-" + time.Now().Format("2006-01-02-15-04-05") + ".txt"`
`27`		`- logFileHandler, err := os.Create(logDir + "/" + fileName)`
	`27`	`+ lfh, err := os.Create(logDir + "/" + fileName)`
`28`	`28`	`if err != nil {`
`29`	`29`	`return nil, err`
`30`	`30`	`}`
	`31`	`+ logFileHandler = lfh`
`31`	`32`
`32`	`33`	`level := slog.LevelDebug`
`33`	`34`	`if !debug {`
`@@ -38,7 +39,7 @@ func NewLogger(debug bool, logDir string) (*slog.Logger, error) {`
`38`	`39`	`Level: level,`
`39`	`40`	`}`
`40`	`41`
`41`		`- handler := slog.NewTextHandler(io.MultiWriter(os.Stdout, logFileHandler), opts)`
	`42`	`+ handler := slog.NewTextHandler(io.MultiWriter(logFileHandler, os.Stdout), opts)`
`42`	`43`
`43`	`44`	`return slog.New(handler), nil`
`44`	`45`	`}`