Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: Choose preferred scheme name. #23

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

oscarssanchez
Copy link

@oscarssanchez oscarssanchez commented May 9, 2018

Hi @helen,

Could you use this PR that aims to add the feature requested in #16 ?

I'm not sure if my approach is intuitive enough to the end user, so it would be great to read some feedback.

So this is what the functionality looks like now:

When no name is provided the scheme name defaults to Custom

Alt Text

Example of adding a name to the custom scheme.

Alt Text

Maybe outputting an error if no scheme name is provided would be a better approach, which would be also related to issue #7

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant