Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions without content changes are wonky :) #1

Open
kraftbj opened this issue Oct 6, 2015 · 1 comment
Open

Revisions without content changes are wonky :) #1

kraftbj opened this issue Oct 6, 2015 · 1 comment

Comments

@kraftbj
Copy link

kraftbj commented Oct 6, 2015

Checked two situations of attempting to leave a note with no other changes:

  1. Post with no revisions
  2. Post with existing revisions

With no revisions, upon save, nothing in the UI changed. No revisions listed (makes sense). Once making any change to content and saving, the original revision note was applied to the initial revision, so that seemingly worked, though perhaps expected the revision UI to appear.

With existing revisions, it seemingly didn't work. I tried to leave a note with no changes, then changed something. The UI reflected each revision correctly with the no-update note seemingly lost.

@helen
Copy link
Owner

helen commented Oct 6, 2015

In both of these situations, the note is still saved to the original post so it'll show up as the latest revision note in the list table. What would your expectations be for each? I could probably do some juggling on the PHP side to not save to the parent post if no revision's been created, but that still leaves a field that a user can fill out and then just disappears into the ether. Will have to mull on how to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants