Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile fails using Rustc 1.80.0 #484

Closed
jthiller opened this issue Jul 26, 2024 · 4 comments · Fixed by #486 · May be fixed by #475
Closed

Compile fails using Rustc 1.80.0 #484

jthiller opened this issue Jul 26, 2024 · 4 comments · Fixed by #486 · May be fixed by #475

Comments

@jthiller
Copy link

Compiling directly on a Raspberry Pi 3 under a new install cargo build fails to complete.

image image

Loading 1.79.0 via rustup lends to a successful build.
image
...
image
@jthiller
Copy link
Author

cargo update time took latest time 0.3.36
Build with rustc 1.80.0 has a couple new warnings on gateway-rs related to the use of time, but completes successfully

@madninja
Copy link
Member

madninja commented Jul 28, 2024 •
edited
Loading

fixed #475

The data ack proto code and support in hpr was merged and deployed a while ago (please confirm @michaeldjeffrey ). I've updated that PR to include the rust upgrade issues.

Note @jthiller that currently the CI build limits rust to 1.72 since there were issues with newer rust async on mipsel . This is also why that PR now breaks since crate upgrades require 1.74 or higher. Can we get some testing on a mipsel target with a 1.80 build?

@madninja madninja linked a pull request Jul 28, 2024 that will close this issue
Data packet acks #475
Open
@madninja madninja mentioned this issue Jul 31, 2024
Merged
@madninja
Copy link
Member

madninja commented Aug 1, 2024

Will need to handle #475 issues separately

@michaeldjeffrey
Copy link
Contributor

The data ack proto code and support in hpr was merged and deployed a while ago (please confirm @michaeldjeffrey ). I've updated that PR to include the rust upgrade issues.

Confirming packet acks are in HPR helium/helium-packet-router#279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update time crate, fix clippy helium/gateway-rs
Data packet acks helium/gateway-rs
3 participants
@madninja @jthiller @michaeldjeffrey